manuzhang commented on code in PR #9605:
URL: https://github.com/apache/iceberg/pull/9605#discussion_r1475670135


##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -313,6 +317,11 @@ public void commit() {
     }
   }
 
+  @Override
+  public long expiredSnapshotsCount() {

Review Comment:
   No existing examples. This PR is separated from 
https://github.com/apache/iceberg/pull/9584 which adds an option not to delete 
files in expire_snapshots. In that case, this count will be useful since all 
other results will be zero.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to