danielcweeks commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475365294
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java:
##########
@@ -182,18 +169,13 @@ private void createTable(String newMetadataLocation)
throws SQLException, Interr
tableIdentifier, catalogName, namespace);
}
+ if (JdbcUtil.viewExists(catalogName, connections, tableIdentifier)) {
Review Comment:
It seems like we should be checking if a table or view exists here. Either
that or we just allow the primary key constraint to fail like I assume it would
if the table already exists currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
