danielcweeks commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475366557


##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOperations.java:
##########
@@ -71,7 +68,7 @@ public void doRefresh() {
     Map<String, String> table;
 
     try {
-      table = getTable();
+      table = JdbcUtil.tableOrView(true, connections, catalogName, 
tableIdentifier);

Review Comment:
   This doesn't look correct.  We should only be loading table in the table 
operations or failing if it is a view.  In the unlikely event someone drops a 
table and creates a view with the same identifier, we shouldn't attempt to load 
that as a table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to