danielcweeks commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1475337646
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -245,13 +286,18 @@ public List<TableIdentifier> listTables(Namespace
namespace) {
row ->
JdbcUtil.stringToTableIdentifier(
row.getString(JdbcUtil.TABLE_NAMESPACE),
row.getString(JdbcUtil.TABLE_NAME)),
- JdbcUtil.LIST_TABLES_SQL,
+ JdbcUtil.LIST_TABLE_SQL,
catalogName,
- JdbcUtil.namespaceToString(namespace));
+ JdbcUtil.namespaceToString(namespace),
+ "TABLE");
Review Comment:
We should probably pull the `TABLE` and `VIEW` literals into static
variables (e.g. `TABLE_RECORD_TYPE` and `VIEW_RECORD_TYPE`) as opposed to
relying on strings here. It's not particularly clear why we're passing this
value as a param.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
