aokolnychyi commented on code in PR #9605:
URL: https://github.com/apache/iceberg/pull/9605#discussion_r1475290568
##########
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##########
@@ -118,4 +118,9 @@ public interface ExpireSnapshots extends
PendingUpdate<List<Snapshot>> {
* @return this for method chaining
*/
ExpireSnapshots cleanExpiredFiles(boolean clean);
+
+ /** Returns number of expired snapshots */
+ default long expiredSnapshotsCount() {
+ return 0L;
Review Comment:
Hm, I think it would be weird to have 0 as the number of expired snapshots
yet have deleted files at the same time. We can consider throwing an
unsupported exception or returning null, however, I am not sure will be any
better. My initial thought would be to throw an exception but I need to think
more about it.
What do you think, @manuzhang @nastra?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
