tomtongue commented on code in PR #9613:
URL: https://github.com/apache/iceberg/pull/9613#discussion_r1475691097
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -489,10 +479,10 @@ public void
addPartitionToPartitionedSnapshotIdInheritanceEnabledInTwoRuns() {
Pattern uuidPattern =
Pattern.compile("[a-f0-9]{8}(?:-[a-f0-9]{4}){4}[a-f0-9]{8}");
Matcher matcher = uuidPattern.matcher(manifestPath);
- Assert.assertTrue("verify manifest path has uuid", matcher.find());
+ Assertions.assertThat(matcher.find()).as("verify manifest path has
uuid").isTrue();
Review Comment:
`matches` is a full string match, so this couldn't pass the test if this
test was changed. Or, change the regex pattern.
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -489,10 +479,10 @@ public void
addPartitionToPartitionedSnapshotIdInheritanceEnabledInTwoRuns() {
Pattern uuidPattern =
Pattern.compile("[a-f0-9]{8}(?:-[a-f0-9]{4}){4}[a-f0-9]{8}");
Matcher matcher = uuidPattern.matcher(manifestPath);
- Assert.assertTrue("verify manifest path has uuid", matcher.find());
+ Assertions.assertThat(matcher.find()).as("verify manifest path has
uuid").isTrue();
Review Comment:
`matches` is a full string match, so this couldn't pass the test if this
test was changed. Or, should I change the regex pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
