wooyeong commented on code in PR #9455:
URL: https://github.com/apache/iceberg/pull/9455#discussion_r1475682472
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -117,7 +119,7 @@ public class SparkTable
.build();
private final Table icebergTable;
- private final Long snapshotId;
+ private Long snapshotId;
Review Comment:
Because we have two different constructors, `snapshotId` is not final be
unless we change the logic, specifically the below part.
```java
this(icebergTable, refreshEagerly); // <- here sets snapshotId
this.branch = branch;
Snapshot snapshot = icebergTable.snapshot(branch);
ValidationException.check(
branch == null || SnapshotRef.MAIN_BRANCH.equals(branch) || snapshot
!= null,
"Cannot use branch (does not exist): %s",
branch);
this.snapshotId = snapshot.snapshotId(); // <- try to set snapshotId
again.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
