stevenzwu commented on issue #9597: URL: https://github.com/apache/iceberg/issues/9597#issuecomment-1922601810
@nastra thanks for the comments! Regarding the JSON format, we are on the same page of adding a new `task-type` or `type` field. Are you suggesting adding a new API `FileScanTask#type()`? I can see the enum type works well for `ReportMetricsRequest`. But I don't know if is most natural with FileScanTask's existing class hierarchy. In my mind, class name (FQCN) is essentially the type. <img width="757" alt="image" src="https://github.com/apache/iceberg/assets/1545663/45941f2a-2683-4c43-b279-fa5a7ff56273";> Class renaming/moving around can be a problem although I don't know if practically we should do that. We can add a unit test to assert the class's FQCN didn't change. if renamed/relocated, the parser needs to be updated to track both old and new names. what's your take on the problem of serializing the `StrucktLike` row? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
