Alona Kaplan has posted comments on this change.
Change subject: engine: Adding unique(vds_id, name) constraint to vds_interface
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42429
To unsubscribe, visit
Alona Kaplan has uploaded a new change for review.
Change subject: engine: Adding unique(vds_id, name) constraint to vds_interface
..
engine: Adding unique(vds_id, name) constraint to vds_interface
and removing duplicate entirie
Alona Kaplan has posted comments on this change.
Change subject: core: refactored NetworkAttachmentCompleter + tests.
..
Patch Set 44:
(20 comments)
https://gerrit.ovirt.org/#/c/36142/44/backend/manager/modules/bll/src/main/ja
Alona Kaplan has posted comments on this change.
Change subject: engine: Add NetworkAttachmentsValidator
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/34968/23/backend/manager/modules/bll/src/main/java/org/ovirt/en
Alona Kaplan has posted comments on this change.
Change subject: core: refactor&test for HostNetworkAttachmentsPersister
..
Patch Set 37:
(3 comments)
https://gerrit.ovirt.org/#/c/36067/37/backend/manager/modules/common/src/ma
Alona Kaplan has posted comments on this change.
Change subject: engine: Add NetworkAttachmentsValidator
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/34968/23/backend/manager/modules/bll/src/main/java/org/ovirt/en
Alona Kaplan has posted comments on this change.
Change subject: core: refactor&test for HostNetworkAttachmentsPersister
..
Patch Set 44:
(4 comments)
https://gerrit.ovirt.org/#/c/36067/44/backend/manager/modules/vdsbroker/src
Alona Kaplan has posted comments on this change.
Change subject: core: refactor of HostNetworkAttachmentPersister
..
Patch Set 43:
(3 comments)
https://gerrit.ovirt.org/#/c/36141/43/backend/manager/modules/vdsbroker/src/main/j
Alona Kaplan has posted comments on this change.
Change subject: core: removed procedural parameter passing
..
Patch Set 41: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/35979
To unsubscribe, visit https://gerrit.o
Alona Kaplan has posted comments on this change.
Change subject: core: validations from LabelNicCommand refactored out to
HostInterfaceValidator
..
Patch Set 40:
(1 comment)
https://gerrit.ovirt.org/#/c/35977/40/backend/manag
Alona Kaplan has posted comments on this change.
Change subject: restapi: Add support for Network Attachements.
..
Patch Set 44:
(4 comments)
https://gerrit.ovirt.org/#/c/32775/44//COMMIT_MSG
Commit Message:
Line 3: AuthorDat
Alona Kaplan has posted comments on this change.
Change subject: engine: Add query to retrieve host's bonds
..
Patch Set 29:
(1 comment)
https://gerrit.ovirt.org/#/c/35378/29/backend/manager/modules/bll/src/main/java/org/ovirt
Alona Kaplan has posted comments on this change.
Change subject: engine: Add query to retrieve host's bonds
..
Patch Set 29: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/35378
To unsubscribe, visit https://gerrit.o
Alona Kaplan has posted comments on this change.
Change subject: engine: Remove nics from
CollectHostNetworkDataVdsCommandParameters
..
Patch Set 29: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/35377
To unsubscri
Alona Kaplan has posted comments on this change.
Change subject: engine: Add query to retrieve host's bonds
..
Patch Set 27: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/35378/27/backend/manager/modules/bll/src/main
Alona Kaplan has posted comments on this change.
Change subject: core: refactored gathering violations to separate class
..
Patch Set 47:
Regarding point 1 and 2 in the general comment- since the validator method
doesn't proce
Alona Kaplan has posted comments on this change.
Change subject: core: refactored gathering violations to separate class
..
Patch Set 47:
(6 comments)
This patch enables dynamically constructing the variable replacement-
{mes
Alona Kaplan has posted comments on this change.
Change subject: webadmin: removing redundant check
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/42165
To unsubscribe, visit https://gerrit
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: removing redundant check
..
webadmin: removing redundant check
Findbugs complain about the test, as it will always be true if the
object is not
Alona Kaplan has posted comments on this change.
Change subject: engine: Remove nics from
CollectHostNetworkDataVdsCommandParameters
..
Patch Set 27: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/35377/27/backend/man
Alona Kaplan has posted comments on this change.
Change subject: core: renamed method
..
Patch Set 44: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ger
Alona Kaplan has posted comments on this change.
Change subject: engine: Replace host polling with HostSetupNetworkPoller
..
Patch Set 28: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/35083
To unsubscribe, visit ht
Alona Kaplan has posted comments on this change.
Change subject: engine: Configure network on install with network attachments
..
Patch Set 29: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/34972
To unsubscribe, vis
Alona Kaplan has posted comments on this change.
Change subject: core: refactored gathering violations to separate class
..
Patch Set 47:
(15 comments)
https://gerrit.ovirt.org/#/c/37154/47/backend/manager/modules/bll/src/main
Alona Kaplan has posted comments on this change.
Change subject: engine: Introduce network attachments command
..
Patch Set 28:
(16 comments)
https://gerrit.ovirt.org/#/c/34971/28/backend/manager/modules/bll/src/main/java/org/
Alona Kaplan has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 35:
(4 comments)
https://gerrit.ovirt.org/#/c/3/35/backend/manager/modules/bll/src/main/java/org/ovi
Alona Kaplan has posted comments on this change.
Change subject: core,restapi: allow indetifying network by its name when adding
network attachment allow indetifying network by its name.
..
Patch Set 16:
(2 comments)
https://
Alona Kaplan has posted comments on this change.
Change subject: core: refactored NetworkAttachmentCompleter + tests.
..
Patch Set 41:
(1 comment)
https://gerrit.ovirt.org/#/c/36142/41/backend/manager/modules/bll/src/main/java
Alona Kaplan has posted comments on this change.
Change subject: core: refactored NetworkAttachmentCompleter + tests.
..
Patch Set 41:
(1 comment)
https://gerrit.ovirt.org/#/c/36142/41/backend/manager/modules/bll/src/main/java
Alona Kaplan has posted comments on this change.
Change subject: core,restapi: allow indetifying network by its name when adding
network attachment allow indetifying network by its name.
..
Patch Set 16:
(1 comment)
https://g
Alona Kaplan has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 26:
(13 comments)
https://gerrit.ovirt.org/#/c/3/26/backend/manager/modules/bll/src/main/java/org/ov
Alona Kaplan has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 35:
(33 comments)
https://gerrit.ovirt.org/#/c/3/35/backend/manager/modules/bll/src/main/java/org/ov
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Adding external status to UI
..
Patch Set 25: Code-Review+2
(3 comments)
There are some minor comments. Please fix them before merging.
https://gerrit
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Adding external status to UI
..
Patch Set 23:
(4 comments)
https://gerrit.ovirt.org/#/c/40999/23/frontend/webadmin/modules/webadmin/src/main/java/org/o
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Adding external status to UI
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/40999/15/frontend/webadmin/modules/webadmin/src/main/java/org/o
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: fix coverity #1302429 and #1302428
..
webadmin: fix coverity #1302429 and #1302428
Change-Id: I0a05a21c1c70f605cefc166159aba0ee349be10c
Signed-
Alona Kaplan has posted comments on this change.
Change subject: webadmin: fix coverity #1302429 and #1302428
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41919
To unsubscribe, visit https://gerrit.ovi
Alona Kaplan has posted comments on this change.
Change subject: engine: Add HostInterfaceValidator
..
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/34969/24/backend/manager/modules/dal/src/main/resources/bundles/AppE
Alona Kaplan has posted comments on this change.
Change subject: engine: Add NetworkAttachmentsValidator
..
Patch Set 24: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/34968
To unsubscribe, visit https://gerrit.ovir
Alona Kaplan has posted comments on this change.
Change subject: engine: Add ModifiedNetworkAttachmentValidator
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/34967/15/backend/manager/modules/bll/src/main/java/org/
Alona Kaplan has posted comments on this change.
Change subject: engine: Re-define HostSetupNetworks based on network attachments
..
Patch Set 33: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/32910
To unsubscribe,
Alona Kaplan has posted comments on this change.
Change subject: core: renamed method
..
Patch Set 40: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/36571/40/backend/manager/modules/bll/src/main/java/org/ovirt/engine/
Alona Kaplan has posted comments on this change.
Change subject: core: tests for NetworkAttachmentValidator
..
Patch Set 40:
(26 comments)
https://gerrit.ovirt.org/#/c/36570/40/backend/manager/modules/bll/src/main/java/org/ovi
Alona Kaplan has posted comments on this change.
Change subject: core: replaced 'unless' with 'when'
..
Patch Set 39: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36569
To unsubscribe, visit https://gerrit.ovirt.or
Alona Kaplan has posted comments on this change.
Change subject: core: Tests for NetworkAttachmentsValidator
..
Patch Set 40:
(6 comments)
https://gerrit.ovirt.org/#/c/36147/40/backend/manager/modules/bll/src/main/java/org/ovi
Alona Kaplan has posted comments on this change.
Change subject: core: refactor: extracted uninteressant hashmap manipulation to
separate method
..
Patch Set 40:
(1 comment)
https://gerrit.ovirt.org/#/c/36146/40/backend/manag
Alona Kaplan has posted comments on this change.
Change subject: core: refactor: renamed variables + extracted creating map
..
Patch Set 39:
(3 comments)
https://gerrit.ovirt.org/#/c/36145/39//COMMIT_MSG
Commit Message:
Line
Alona Kaplan has posted comments on this change.
Change subject: core: refactor; encapsulation
..
Patch Set 39: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36143
To unsubscribe, visit https://gerrit.ovirt.org/sett
Alona Kaplan has posted comments on this change.
Change subject: core: refactored NetworkAttachmentCompleter + tests.
..
Patch Set 37:
(7 comments)
https://gerrit.ovirt.org/#/c/36142/37//COMMIT_MSG
Commit Message:
Line 6:
Li
Alona Kaplan has posted comments on this change.
Change subject: engine: Block provide type change
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41934
To unsubscribe, visit https://gerrit.ovirt.org/s
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: fix coverity #1302429 and #1302428
..
webadmin: fix coverity #1302429 and #1302428
Change-Id: I0a05a21c1c70f605cefc166159aba0ee349be10c
Signed-off-by:
Alona Kaplan has posted comments on this change.
Change subject: core: refactor&test for HostNetworkAttachmentsPersister
..
Patch Set 37:
(1 comment)
https://gerrit.ovirt.org/#/c/36067/37/backend/manager/modules/vdsbroker/src/
Alona Kaplan has posted comments on this change.
Change subject: core: refactor&test for HostNetworkAttachmentsPersister
..
Patch Set 37:
(13 comments)
https://gerrit.ovirt.org/#/c/36067/37/backend/manager/modules/common/src/m
Alona Kaplan has posted comments on this change.
Change subject: core: refactor of HostNetworkAttachmentPersister
..
Patch Set 36:
(1 comment)
https://gerrit.ovirt.org/#/c/36141/36/backend/manager/modules/vdsbroker/src/main/ja
Alona Kaplan has posted comments on this change.
Change subject: core: refactor of HostNetworkAttachmentPersister
..
Patch Set 36:
(4 comments)
https://gerrit.ovirt.org/#/c/36141/36/backend/manager/modules/vdsbroker/src/main/j
Alona Kaplan has posted comments on this change.
Change subject: core,userportal,webadmin: missing translations
..
Patch Set 36:
(10 comments)
https://gerrit.ovirt.org/#/c/35980/36/backend/manager/modules/dal/src/main/resource
Alona Kaplan has posted comments on this change.
Change subject: restapi: Add support for Network Attachements.
..
Patch Set 38:
(8 comments)
https://gerrit.ovirt.org/#/c/32775/38//COMMIT_MSG
Commit Message:
Line 3: AuthorDat
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Hiding virt network fields in gluster mode
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41480
To unsubscribe, visit https:/
Alona Kaplan has posted comments on this change.
Change subject: engine: Re-define HostSetupNetworks based on network attachments
..
Patch Set 32:
(2 comments)
https://gerrit.ovirt.org/#/c/32910/32/backend/manager/modules/comm
Alona Kaplan has posted comments on this change.
Change subject: core: removed procedural parameter passing
..
Patch Set 35: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/35979
To unsubscribe, visit https://gerrit.o
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Adding external status to UI
..
Patch Set 15:
(4 comments)
https://gerrit.ovirt.org/#/c/40999/15/frontend/webadmin/modules/webadmin/src/main/java/org/o
Alona Kaplan has posted comments on this change.
Change subject: engine: Introduce HostSetupNetworks command
..
Patch Set 26:
(1 comment)
https://gerrit.ovirt.org/#/c/3/26/backend/manager/modules/vdsbroker/src/main/java/or
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Hiding virt network fields in gluster mode
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/41480/4/frontend/webadmin/modules/webadmin/src/main
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Hiding virt network fields in gluster mode
..
Patch Set 4:
(3 comments)
NetworkModel.setSupportBridgesReportByVDSM- in case the bridges report is not
Alona Kaplan has posted comments on this change.
Change subject: engine: VfScheduler shouldn't override the hostToVnicToVf
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41860
To unsubscribe, visit https
Alona Kaplan has uploaded a new change for review.
Change subject: engine: VfScheduler shouldn't override the hostToVnicToVf
..
engine: VfScheduler shouldn't override the hostToVnicToVf
VfScheduler shouldn't override the hostToV
Alona Kaplan has posted comments on this change.
Change subject: core: refactored HostSetupNetworksValidator to use
HostInterfaceValidator
..
Patch Set 32: Code-Review+2
(7 comments)
https://gerrit.ovirt.org/#/c/35978/32/back
Alona Kaplan has posted comments on this change.
Change subject: core: validations from LabelNicCommand refactored out to
HostInterfaceValidator
..
Patch Set 30:
(1 comment)
https://gerrit.ovirt.org/#/c/35977/30/backend/manag
Alona Kaplan has submitted this change and it was merged.
Change subject: core: Extend Bond entity to contain slaves
..
core: Extend Bond entity to contain slaves
Change-Id: I2d657f759b402d4841f1dc62567490003912dd4f
Signed-off-
Alona Kaplan has posted comments on this change.
Change subject: core: Extend Bond entity to contain slaves
..
Patch Set 29: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/32909
To unsubscribe, visit https://gerrit.o
Alona Kaplan has submitted this change and it was merged.
Change subject: core: Introduce HostSetupNetworksParameters parameters
..
core: Introduce HostSetupNetworksParameters parameters
The HostSetupNetworksParameters are the
Alona Kaplan has posted comments on this change.
Change subject: core: Introduce HostSetupNetworksParameters parameters
..
Patch Set 28: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/32776
To unsubscribe, visit http
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add NetworkAttachment dao
..
engine: Add NetworkAttachment dao
Change-Id: I84187f3900b9e3f8a917fc4e4126de9e50e231b4
Signed-off-by: Moti Asayag
-
Alona Kaplan has posted comments on this change.
Change subject: engine: Add NetworkAttachment dao
..
Patch Set 29: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/32581
To unsubscribe, visit https://gerrit.ovirt.org/
Alona Kaplan has posted comments on this change.
Change subject: core: Introduce NetworkAttachment entity
..
Patch Set 24: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/32411
To unsubscribe, visit https://gerrit.ovi
Alona Kaplan has submitted this change and it was merged.
Change subject: core: Introduce NetworkAttachment entity
..
core: Introduce NetworkAttachment entity
The class is used for describing a network which is
attached to a ne
Alona Kaplan has submitted this change and it was merged.
Change subject: core: Introduce BusinessEntityMap
..
core: Introduce BusinessEntityMap
The map allows to identify a Nameable business entity
within the map either by its
Alona Kaplan has posted comments on this change.
Change subject: core: validations from LabelNicCommand refactored out to
HostInterfaceValidator
..
Patch Set 30:
(5 comments)
https://gerrit.ovirt.org/#/c/35977/30/backend/mana
Alona Kaplan has posted comments on this change.
Change subject: engine: Add query to retrieve host's bonds
..
Patch Set 19:
(2 comments)
https://gerrit.ovirt.org/#/c/35378/19/backend/manager/modules/bll/src/main/java/org/ovir
Alona Kaplan has posted comments on this change.
Change subject: engine: Remove nics from
CollectHostNetworkDataVdsCommandParameters
..
Patch Set 19: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/35377/19/backend/man
Alona Kaplan has posted comments on this change.
Change subject: engine: Re-construct SetupNetworks steps
..
Patch Set 19: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/35376
To unsubscribe, visit https://gerrit.ovi
Alona Kaplan has posted comments on this change.
Change subject: engine: Replace host polling with HostSetupNetworkPoller
..
Patch Set 20: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/35083
To unsubscribe, visit ht
Alona Kaplan has posted comments on this change.
Change subject: engine: Configure network on install with network attachments
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/34972/21/backend/manager/modules/bll/src/
Alona Kaplan has posted comments on this change.
Change subject: engine: Add network attachments queries
..
Patch Set 25: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/33926
To unsubscribe, visit https://gerrit.ovir
Alona Kaplan has posted comments on this change.
Change subject: engine: Introduce network attachments command
..
Patch Set 21:
(9 comments)
https://gerrit.ovirt.org/#/c/34971/21/backend/manager/modules/bll/src/main/java/org/o
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: When creating/extending a bond the labels shouldn't
disappear
..
webadmin: When creating/extending a bond the labels shouldn't disappear
The l
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: setup networks- disable adding labels by editing the
nic
..
webadmin: setup networks- disable adding labels by editing the nic
Preparation for
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Change Setup Networks label mechanism
..
webadmin: Change Setup Networks label mechanism
Changed the labelling/unlabelling mechanism in the Set
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: make networkItemPanel.item generic
..
webadmin: make networkItemPanel.item generic
Change-Id: I8398db46c0c4b6f46d963221aeffa29e9360ce16
Signed-
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: move 'set safe' after changing 'num of vfs'
..
webadmin: move 'set safe' after changing 'num of vfs'
'NumOfVfs' is beeing persisted after setti
Alona Kaplan has posted comments on this change.
Change subject: webadmin: When creating/extending a bond the labels shouldn't
disappear
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41539
To unsubscri
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: When creating/extending a bond the labels shouldn't
disappear
..
webadmin: When creating/extending a bond the labels shouldn't disappear
The labels fr
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Change Setup Networks label mechanism
..
Patch Set 8:
When creating bond of nics with labels, joining bonds and adding nics to a
bond- the labels of th
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Change Setup Networks label mechanism
..
Patch Set 8:
(5 comments)
https://gerrit.ovirt.org/#/c/38773/8/frontend/webadmin/modules/uicommonweb/src/main/
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Change Setup Networks label mechanism
..
Patch Set 9: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/38773
To unsubscribe, visit h
Alona Kaplan has posted comments on this change.
Change subject: webadmin: setup networks- diable adding labels by editing the
nic
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41524
To unsubscribe, vi
Alona Kaplan has posted comments on this change.
Change subject: webadmin: make networkItemPanel.item generic
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41523
To unsubscribe, visit https://gerrit.ovi
Alona Kaplan has posted comments on this change.
Change subject: engine: RefreshHostDevicesCommand- remove entries from table
before adding
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41521
To unsubs
Alona Kaplan has posted comments on this change.
Change subject: webadmin: move 'set safe' after changing 'num of vfs'
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41522
To unsubscribe, visit https://g
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: make networkItemPanel.item generic
..
webadmin: make networkItemPanel.item generic
Change-Id: I8398db46c0c4b6f46d963221aeffa29e9360ce16
Signed-off-by:
1 - 100 of 2980 matches
Mail list logo
