Alona Kaplan has posted comments on this change. Change subject: engine: Add query to retrieve host's bonds ......................................................................
Patch Set 29: (1 comment) https://gerrit.ovirt.org/#/c/35378/29/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetHostBondsByHostIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetHostBondsByHostIdQuery.java: Line 28: List<VdsNetworkInterface> nics = interfaceDao.getAllInterfacesForVds(getParameters().getId()); Line 29: getQueryReturnValue().setReturnValue(initAndGetBonds(nics)); Line 30: } Line 31: Line 32: private List<VdsNetworkInterface> initAndGetBonds(List<VdsNetworkInterface> nics) { I would call it, getBondsWithSlavesInformation(..) and will move this method (and the next one) to NetworkUtil. But as you wish, gave you the +2. Line 33: Map<String, List<String>> bondNameToSlavesMap = getBondNameToBondSlavesMap(nics); Line 34: List<VdsNetworkInterface> bonds = new ArrayList<>(); Line 35: Line 36: for (VdsNetworkInterface nic : nics) { -- To view, visit https://gerrit.ovirt.org/35378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41a632340312bc484c8e33699353b075aa45b1a4 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
