Alona Kaplan has posted comments on this change. Change subject: core: validations from LabelNicCommand refactored out to HostInterfaceValidator ......................................................................
Patch Set 30: (1 comment) https://gerrit.ovirt.org/#/c/35977/30/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidatorTest.java: Line 131: @Test Line 132: public void testAddLabelToNicAndValidateWhenUsingInvalidLabel() throws Exception { Line 133: VdsNetworkInterface vdsNetworkInterface = createVdsNetworkInterfaceWithName(); Line 134: vdsNetworkInterface.setLabels(new HashSet<String>()); Line 135: assertThat(new HostInterfaceValidator(vdsNetworkInterface).addLabelToNicAndValidate("☠☠uups!☠☠", > ☠ :) Consider changing the skull to * for example. Line 136: new ArrayList<Class<?>>()), Line 137: failsWith(VdcBllMessages.IMPROPER_INTERFACE_IS_LABELED)); Line 138: } Line 139: -- To view, visit https://gerrit.ovirt.org/35977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3039fb4a92627036582f03147526522b19c1a2e5 Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
