Alona Kaplan has posted comments on this change. Change subject: core,userportal,webadmin: missing translations ......................................................................
Patch Set 36: (10 comments) https://gerrit.ovirt.org/#/c/35980/36/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Please make the messages more informative. Since they will be thrown upon a hostSetupNetworks command, without this information it will be very hard for the user to understand what is the problematic nic/attachment. Line 1: DIRECTORY_GROUP_CANNOT_REMOVE_DIRECTORY_GROUP_ATTACHED_TO_VM_POOL=Cannot remove Directory Group. Detach Group from VM-Pool first. Line 2: IO_CD_IMAGE_FILE_ALREADY_EXIST=Image file already exists. Line 3: IO_CD_IMAGE_FILE_NOT_EXIST=Image file does not exist. Line 4: IO_INVALID_CD_IMAGE_EXTENSION=Invalid CD image extension. Line 533: NETWORK_INTERFACE_ALREADY_IN_BOND=Network Interface already belongs to the bond. Line 534: NIC_NOT_EXISTS_ON_HOST=Cannot ${action} ${type}. The given network interface does not exist on specified host. Line 535: NETWORK_INTERFACE_BOND_OR_VLAN_CANNOT_BE_SLAVE=Neither bond nor vlan can be slave. Line 536: CANNOT_ADD_NETWORK_ATTACHMENT_ON_SLAVE_OR_VLAN=Cannot ${action} ${type}. Cannot create Network Attachment directly on slave or vlan interface. Line 537: NETWORK_INTERFACE_ATTACHED_TO_NETWORK_CANNOT_BE_SLAVE=Network Interface cannot become slave, there's network attached to it. Please add details to the error- Network Interface $ifaceName cannot become slave, there's network ($netName) attached to it. Line 538: BOND_USED_BY_NETWORK_ATTACHMENTS=Cannot remove bond, because it's used by Network Attachments. Line 539: NETWORK_ATTACHMENT_NOT_EXISTS=Cannot ${action} ${type}. Given Network Attachment does not exist Line 540: NETWORK_ALREADY_ATTACHED_TO_HOST=Cannot ${action} ${type}. Given network is already attached to given host. Line 541: CANNOT_CHANGE_ATTACHED_NETWORK=Cannot ${action} ${type}. Network of given Network Attachment cannot be updated. Line 534: NIC_NOT_EXISTS_ON_HOST=Cannot ${action} ${type}. The given network interface does not exist on specified host. Line 535: NETWORK_INTERFACE_BOND_OR_VLAN_CANNOT_BE_SLAVE=Neither bond nor vlan can be slave. Line 536: CANNOT_ADD_NETWORK_ATTACHMENT_ON_SLAVE_OR_VLAN=Cannot ${action} ${type}. Cannot create Network Attachment directly on slave or vlan interface. Line 537: NETWORK_INTERFACE_ATTACHED_TO_NETWORK_CANNOT_BE_SLAVE=Network Interface cannot become slave, there's network attached to it. Line 538: BOND_USED_BY_NETWORK_ATTACHMENTS=Cannot remove bond, because it's used by Network Attachments. Cannot remove bond $bondName, because it's used by Network Attachments ($attachmentsIds). Line 539: NETWORK_ATTACHMENT_NOT_EXISTS=Cannot ${action} ${type}. Given Network Attachment does not exist Line 540: NETWORK_ALREADY_ATTACHED_TO_HOST=Cannot ${action} ${type}. Given network is already attached to given host. Line 541: CANNOT_CHANGE_ATTACHED_NETWORK=Cannot ${action} ${type}. Network of given Network Attachment cannot be updated. Line 542: ACTION_TYPE_FAILED_DISPLAY_NETWORK_HAS_NO_BOOT_PROTOCOL=Display network hasn't boot protocol assigned. Line 535: NETWORK_INTERFACE_BOND_OR_VLAN_CANNOT_BE_SLAVE=Neither bond nor vlan can be slave. Line 536: CANNOT_ADD_NETWORK_ATTACHMENT_ON_SLAVE_OR_VLAN=Cannot ${action} ${type}. Cannot create Network Attachment directly on slave or vlan interface. Line 537: NETWORK_INTERFACE_ATTACHED_TO_NETWORK_CANNOT_BE_SLAVE=Network Interface cannot become slave, there's network attached to it. Line 538: BOND_USED_BY_NETWORK_ATTACHMENTS=Cannot remove bond, because it's used by Network Attachments. Line 539: NETWORK_ATTACHMENT_NOT_EXISTS=Cannot ${action} ${type}. Given Network Attachment does not exist Missing '.' at the end of the line. Cannot ${action} ${type}. Given Network Attachment $attachmentId does not exist. Line 540: NETWORK_ALREADY_ATTACHED_TO_HOST=Cannot ${action} ${type}. Given network is already attached to given host. Line 541: CANNOT_CHANGE_ATTACHED_NETWORK=Cannot ${action} ${type}. Network of given Network Attachment cannot be updated. Line 542: ACTION_TYPE_FAILED_DISPLAY_NETWORK_HAS_NO_BOOT_PROTOCOL=Display network hasn't boot protocol assigned. Line 543: NETWORK_INVALID_BOND_NAME=Bond name must be formatted as <bondYYY>. Line 536: CANNOT_ADD_NETWORK_ATTACHMENT_ON_SLAVE_OR_VLAN=Cannot ${action} ${type}. Cannot create Network Attachment directly on slave or vlan interface. Line 537: NETWORK_INTERFACE_ATTACHED_TO_NETWORK_CANNOT_BE_SLAVE=Network Interface cannot become slave, there's network attached to it. Line 538: BOND_USED_BY_NETWORK_ATTACHMENTS=Cannot remove bond, because it's used by Network Attachments. Line 539: NETWORK_ATTACHMENT_NOT_EXISTS=Cannot ${action} ${type}. Given Network Attachment does not exist Line 540: NETWORK_ALREADY_ATTACHED_TO_HOST=Cannot ${action} ${type}. Given network is already attached to given host. NETWORK_ALREADY_ATTACHED_TO_HOST=Cannot ${action} ${type}. Network $netName is already attached to given host $hostName. Line 541: CANNOT_CHANGE_ATTACHED_NETWORK=Cannot ${action} ${type}. Network of given Network Attachment cannot be updated. Line 542: ACTION_TYPE_FAILED_DISPLAY_NETWORK_HAS_NO_BOOT_PROTOCOL=Display network hasn't boot protocol assigned. Line 543: NETWORK_INVALID_BOND_NAME=Bond name must be formatted as <bondYYY>. Line 544: NETWORK_INTERFACE_NOT_EXISTS=Network name doesn't exist. Line 537: NETWORK_INTERFACE_ATTACHED_TO_NETWORK_CANNOT_BE_SLAVE=Network Interface cannot become slave, there's network attached to it. Line 538: BOND_USED_BY_NETWORK_ATTACHMENTS=Cannot remove bond, because it's used by Network Attachments. Line 539: NETWORK_ATTACHMENT_NOT_EXISTS=Cannot ${action} ${type}. Given Network Attachment does not exist Line 540: NETWORK_ALREADY_ATTACHED_TO_HOST=Cannot ${action} ${type}. Given network is already attached to given host. Line 541: CANNOT_CHANGE_ATTACHED_NETWORK=Cannot ${action} ${type}. Network of given Network Attachment cannot be updated. Cannot ${action} ${type}. The Network of a Network Attachment cannot be updated (problematic attachment- $attachmentId). Line 542: ACTION_TYPE_FAILED_DISPLAY_NETWORK_HAS_NO_BOOT_PROTOCOL=Display network hasn't boot protocol assigned. Line 543: NETWORK_INVALID_BOND_NAME=Bond name must be formatted as <bondYYY>. Line 544: NETWORK_INTERFACE_NOT_EXISTS=Network name doesn't exist. Line 545: ERROR_CANNOT_ATTACH_MORE_THAN_ONE_ISO_DOMAIN=Cannot attach more than one ISO Storage Domain to the same Data Center. If you want to use a newly created Domain, detach the existing attached Domain and attach the new one. Line 538: BOND_USED_BY_NETWORK_ATTACHMENTS=Cannot remove bond, because it's used by Network Attachments. Line 539: NETWORK_ATTACHMENT_NOT_EXISTS=Cannot ${action} ${type}. Given Network Attachment does not exist Line 540: NETWORK_ALREADY_ATTACHED_TO_HOST=Cannot ${action} ${type}. Given network is already attached to given host. Line 541: CANNOT_CHANGE_ATTACHED_NETWORK=Cannot ${action} ${type}. Network of given Network Attachment cannot be updated. Line 542: ACTION_TYPE_FAILED_DISPLAY_NETWORK_HAS_NO_BOOT_PROTOCOL=Display network hasn't boot protocol assigned. Display network ($netName) hasn't boot protocol assigned Line 543: NETWORK_INVALID_BOND_NAME=Bond name must be formatted as <bondYYY>. Line 544: NETWORK_INTERFACE_NOT_EXISTS=Network name doesn't exist. Line 545: ERROR_CANNOT_ATTACH_MORE_THAN_ONE_ISO_DOMAIN=Cannot attach more than one ISO Storage Domain to the same Data Center. If you want to use a newly created Domain, detach the existing attached Domain and attach the new one. Line 546: ERROR_CANNOT_ATTACH_MORE_THAN_ONE_EXPORT_DOMAIN=Cannot attach more than one Import/Export Storage Domain to the same Data Center. If you want to use a newly created Domain, detach the existing attached Domain and attach the new one. Line 847: IMPROPER_INTERFACE_IS_LABELED=Cannot ${action} ${type}. An improper network interface is labeled. Please verify labels are provided only to interfaces or to bonds (not to slaves nor vlans). Line 848: IMPROPER_BOND_IS_LABELED=Cannot ${action} ${type}. An improper bond is labeled. Please verify labels are provided only to bonds with at least two slaves. Line 849: INTERFACE_ALREADY_LABELED=Cannot ${action} ${type}. The network interface is already labeled with the specified label. Line 850: INTERFACE_NOT_LABELED=Cannot ${action} ${type}. The network interface is not labeled with the specified label. Line 851: NETWORK_INTERFACE_IS_NOT_BOND=Cannot ${action} ${type}. The given network interface is not a bond. Cannot ${action} ${type}. Network interface $ifaceName is not a bond. Line 852: MISSING_DIRECTORY_ELEMENT_ID=User/group ID cannot be empty. Line 853: NETWORK_ILEGAL_NETWORK_NAME=Network name must be 1-15 long and can contain only 'A-Z', 'a-z', '0-9', '_', '-' characters Line 854: STORAGE_OPERATION_FAILED_SPM_NETWORK_PROBLEMS=Storage related operations can't be performed while the Storage Pool Manager is down.\nPlease make sure the Storage Pool Manager is up and running, and check network connectivity. Line 855: VALIDATION_STORAGE_CONNECTION_INVALID=Mount path is illegal, please use [IP:/path or FQDN:/path] convention. https://gerrit.ovirt.org/#/c/35980/36/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: The setup network errors are not relevant to user portal Line 1: DIRECTORY_GROUP_CANNOT_REMOVE_DIRECTORY_GROUP_ATTACHED_TO_VM_POOL=Cannot remove Directory Group. Detach Group from VM-Pool first. Line 2: IO_CD_IMAGE_FILE_ALREADY_EXIST=Image file already exists. Line 3: IO_CD_IMAGE_FILE_NOT_EXIST=Image file does not exist. Line 4: IO_INVALID_CD_IMAGE_EXTENSION=Invalid CD image extension. Line 475: BOND_USED_BY_NETWORK_ATTACHMENTS=Cannot remove bond, because it's used by Network Attachments. Line 476: NETWORK_ATTACHMENT_NOT_EXISTS=Cannot ${action} ${type}. Given Network Attachment does not exist Line 477: NETWORK_ALREADY_ATTACHED_TO_HOST=Cannot ${action} ${type}. Given network is already attached to given host. Line 478: CANNOT_CHANGE_ATTACHED_NETWORK=Cannot ${action} ${type}. Network of given Network Attachment cannot be updated. Line 479: ACTION_TYPE_FAILED_DISPLAY_NETWORK_HAS_NO_BOOT_PROTOCOL=Display network hasn't boot protocol assigned. What about NETWORK_INTERFACE_IS_NOT_BOND? (Although as I wrote in the previous comment, you can remove all the errors from this file...) Line 480: NETWORK_INVALID_BOND_NAME=Bond name must be formatted as <bondYYY>. Line 481: NETWORK_INTERFACE_NOT_EXISTS=Network name doesn't exist. Line 482: ERROR_CANNOT_ATTACH_MORE_THAN_ONE_ISO_DOMAIN=Cannot attach more than one ISO Storage Domain to the same Data Center. If you want to use a newly created Domain, detach the existing attached Domain and attach the new one. Line 483: ERROR_CANNOT_ATTACH_MORE_THAN_ONE_EXPORT_DOMAIN=Cannot attach more than one Import/Export Storage Domain to the same Data Center. If you want to use a newly created Domain, detach the existing attached Domain and attach the new one. -- To view, visit https://gerrit.ovirt.org/35980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd0d874f69144fe647ffe9b32bd6fe8f6864e317 Gerrit-PatchSet: 36 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
