Alona Kaplan has posted comments on this change. Change subject: core: validations from LabelNicCommand refactored out to HostInterfaceValidator ......................................................................
Patch Set 40: (1 comment) https://gerrit.ovirt.org/#/c/35977/40/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java: Line 85: Line 86: private IpConfiguration createIpConfigurationFromVdsNetworkInterface(VdsNetworkInterface nic) { Line 87: IpConfiguration ipConfiguration = new IpConfiguration(); Line 88: ipConfiguration.setBootProtocol(nic.getBootProtocol()); Line 89: ipConfiguration.getPrimaryAddress().setAddress(nic.getAddress()); IIUC, you will get IllegalStateException here, since 'PrimaryAddress' is not set. Line 90: ipConfiguration.getPrimaryAddress().setNetmask(nic.getSubnet()); Line 91: ipConfiguration.getPrimaryAddress().setGateway(nic.getGateway()); Line 92: Line 93: return ipConfiguration; -- To view, visit https://gerrit.ovirt.org/35977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3039fb4a92627036582f03147526522b19c1a2e5 Gerrit-PatchSet: 40 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
