Alona Kaplan has posted comments on this change. Change subject: core: refactor: extracted uninteressant hashmap manipulation to separate method ......................................................................
Patch Set 40: (1 comment) https://gerrit.ovirt.org/#/c/36146/40/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java: Line 66: } Line 67: return nicNameToNetworkTypes; Line 68: } Line 69: Line 70: //TODO MM: use MultiValueMapUtils The patch cannot be merged with TODO leftovers. So either use MultiValueMapUtils or just remove the comment. Line 71: private List<NetworkType> getNetworkTypesList(Map<String, List<NetworkType>> nicNameToNetworkTypes, String nicName) { Line 72: if (nicName == null) { Line 73: throw new IllegalArgumentException("nic name cannot be null"); Line 74: } -- To view, visit https://gerrit.ovirt.org/36146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bbeebec517e7ac3e9897003447d5a6290792201 Gerrit-PatchSet: 40 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
