Alona Kaplan has posted comments on this change. Change subject: engine: Introduce HostSetupNetworks command ......................................................................
Patch Set 35: (4 comments) https://gerrit.ovirt.org/#/c/33333/35/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java: Line 155: existingIfacesById); Line 156: if (!invalidBondIds.isEmpty()) { Line 157: for (Guid problematicId : invalidBondIds) { Line 158: addViolation(VdcBllMessages.NETWORK_BOND_NOT_EXISTS, problematicId.toString()); Line 159: > This AppErrors message of 'NETWORK_BOND_NOT_EXISTS' doesn't contain a place Also. what if the bond exists, but on another host. You can have a general message for both of the cases- Bond $nameOrId doesn't exist on the specified host. Line 160: } Line 161: return false; Line 162: } Line 163: Line 234: existingIfaces What if the bond exists but configured on another host. You should have a validation for that. Line 335: } Line 336: Line 337: String networkId = attachment.getNetworkId() == null ? "" : attachment.getNetworkId().toString(); Line 338: if (!(validate(validator.networkExists(), networkId) Line 339: && validate(referencedNetworkAttachmentActuallyExists(attachment.getId()), networkId) > The error message is- "Cannot ${action} ${type}. Given Network Attachment d Also maybe the attachment exists, but not on the specified host. So the message can be- "Cannot ${action} ${type}. Network Attachment ${nameOrId} does not exist on the specified host" Line 340: && validate(validator.notExternalNetwork(), networkId) Line 341: && validate(validator.networkAttachedToCluster(), networkId) Line 342: && validate(validator.ipConfiguredForStaticBootProtocol(), networkId) Line 343: && validate(validator.bootProtocolSetForDisplayNetwork(), networkId) Line 375: NETWORK_ATTACHMENT_NOT_EXISTS Refer to the comment in line 339. -- To view, visit https://gerrit.ovirt.org/33333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60077019f308f371f21fb7b5545ba48adb38bd06 Gerrit-PatchSet: 35 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
