Alona Kaplan has posted comments on this change. Change subject: webadmin: Adding external status to UI ......................................................................
Patch Set 25: Code-Review+2 (3 comments) There are some minor comments. Please fix them before merging. https://gerrit.ovirt.org/#/c/40999/25/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/EntityAdditionalStatusColumn.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/EntityAdditionalStatusColumn.java: Line 32: return SafeHtmlUtils.fromTrustedString(AbstractImagePrototype. Line 33: create(imageResource).getHTML()); Line 34: } Line 35: Line 36: abstract protected SafeHtml getEntityValue(S s); Consider moving the abstract after the access modifier. Line 37: Line 38: abstract protected SafeHtml getEntityTooltip(S object); Line 39: Line 40: abstract protected S getEntityObject(S object); Line 34: } Line 35: Line 36: abstract protected SafeHtml getEntityValue(S s); Line 37: Line 38: abstract protected SafeHtml getEntityTooltip(S object); same Line 39: Line 40: abstract protected S getEntityObject(S object); Line 41: Line 42: @Override Line 36: abstract protected SafeHtml getEntityValue(S s); Line 37: Line 38: abstract protected SafeHtml getEntityTooltip(S object); Line 39: Line 40: abstract protected S getEntityObject(S object); same Line 41: Line 42: @Override Line 43: public SafeHtml getValue(S object) { Line 44: if (getEntityObject(object) == null) { -- To view, visit https://gerrit.ovirt.org/40999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99e7066176e70ec94f543aa1120bb355acad9b0a Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
