Alona Kaplan has posted comments on this change. Change subject: engine: Add NetworkAttachmentsValidator ......................................................................
Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/34968/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java: Line 20: * The {@code NetworkAttachmentsValidator} performs validation on the entire network attachments as a whole and for Line 21: * cross network attachments configuration. For a specific network attachment entity validation use Line 22: * {@link org.ovirt.engine.core.bll.validator.NetworkAttachmentValidator}; Line 23: */ Line 24: public class NetworkAttachmentsValidator { Please refer to- https://gerrit.ovirt.org/#/c/36067/37/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java You should have a validation that make sure the user didn't pass the same network on more than one attachment. Line 25: Line 26: private final Collection<NetworkAttachment> attachmentsToConfigure; Line 27: private final Map<Guid, Network> clusterNetworks; Line 28: -- To view, visit https://gerrit.ovirt.org/34968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92771cc35560ff4101231c3c7a40e6becbe3e8f2 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
