Alona Kaplan has posted comments on this change. Change subject: core: refactor of HostNetworkAttachmentPersister ......................................................................
Patch Set 36: (1 comment) https://gerrit.ovirt.org/#/c/36141/36/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java: Line 112: //TODO MM: what if attachment has nicID already assigned? Line 113: for (NetworkAttachment attachment : userNetworkAttachments) { Line 114: boolean userAttachmentReferencesNetworkBoundToNic = networkConfiguredOnHost(attachment.getNetworkId()); Line 115: if (userAttachmentReferencesNetworkBoundToNic) { Line 116: VdsNetworkInterface nicToWhichIsNetworkBound = reportedNicsByNetworkId.get(attachment.getNetworkId()); reportedNicToWhichNetworkAttached Line 117: attachment.setNicId(baseInterfaceOfNic(nicToWhichIsNetworkBound).getId()); Line 118: boolean alreadyExistingAttachment = dbAttachmentsById.containsKey(attachment.getId()); Line 119: Line 120: if (alreadyExistingAttachment) { -- To view, visit https://gerrit.ovirt.org/36141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibecf02fe47f42c2184c1f010f794592944c55e62 Gerrit-PatchSet: 36 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
