[Engine-patches] Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...

2013-04-24 Thread derez
Daniel Erez has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups .. Patch Set 5: No score (1 inline comment) ..

[Engine-patches] Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...

2013-04-24 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups .. Patch Set 5: (1 inline comment) File

[Engine-patches] Change in ovirt-engine[master]: core: Remove get image info call before images commands

2013-04-24 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Remove get image info call before images commands .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...

2013-04-24 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups .. Patch Set 5: (1 inline comment) File

[Engine-patches] Change in ovirt-engine[master]: core: block VM migration during live storage migration

2013-04-24 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: block VM migration during live storage migration .. core: block VM migration during live storage migration This is a best-effort fix for preventing

[Engine-patches] Change in ovirt-engine[master]: core: block VM migration during live storage migration

2013-04-24 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: block VM migration during live storage migration .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14122 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: block VM migration during live storage migration

2013-04-24 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: block VM migration during live storage migration .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/14122 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: [cleanup] organize canMigrateVm method

2013-04-24 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: [cleanup] organize canMigrateVm method .. Patch Set 4: (1 inline comment) File backend/manager/modules

[Engine-patches] Change in ovirt-engine[master]: userportal: Fix legend localization

2013-04-24 Thread omasad
ofri masad has uploaded a new change for review. Change subject: userportal: Fix legend localization .. userportal: Fix legend localization Legend panel in the three info boxes of the resource view was too narrow to hold the thr

[Engine-patches] Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...

2013-04-24 Thread derez
Daniel Erez has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups .. Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...

2013-04-24 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups .. Patch Set 5: Asaf, please look at the other related bugs, and provide patches for them, i

[Engine-patches] Change in ovirt-engine[master]: core: Remove get image info call before images commands

2013-04-24 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Remove get image info call before images commands .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/13994 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...

2013-04-24 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11893 T

[Engine-patches] Change in ovirt-engine[master]: core: Rename storage_pool entity to StoragePool

2013-04-24 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Rename storage_pool entity to StoragePool .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14208 To

[Engine-patches] Change in ovirt-engine[master]: frontend: Fix findbug errors in Linq.java

2013-04-24 Thread derez
Daniel Erez has posted comments on this change. Change subject: frontend: Fix findbug errors in Linq.java .. Patch Set 1: (2 inline comments) File frontend/webadmin/modules/

[Engine-patches] Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...

2013-04-24 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: restapi:Correct rsdl for add bricks

2013-04-24 Thread sabose
Sahina Bose has posted comments on this change. Change subject: restapi:Correct rsdl for add bricks .. Patch Set 3: Verified verified - add brick --cluster-identifier "GlusterC" --glustervolume-identifier "Repl" --brick "bric

[Engine-patches] Change in ovirt-engine[master]: restapi:Correct rsdl for add bricks

2013-04-24 Thread sabose
Sahina Bose has posted comments on this change. Change subject: restapi:Correct rsdl for add bricks .. Patch Set 1: (2 inline comments) Uploading new patchset File backend/

[Engine-patches] Change in ovirt-engine[master]: core: Rename storage_pool entity to StoragePool

2013-04-24 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Rename storage_pool entity to StoragePool .. Patch Set 1: (3 inline comments) File backend/manager/module

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: branding support.

2013-04-24 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: branding support. .. Patch Set 9: Fails Added packaging support: Makefile, spec -- To view, visit http://gerrit.ovirt.org/13181 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: branding support.

2013-04-24 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: branding support. .. Patch Set 8: Fails I built rpm and installed, without any branding package installed, I expect business as usual, but

[Engine-patches] Change in ovirt-engine[master]: restapi: WIP: Created restapi interface for backup.

2013-04-24 Thread Sharad Mishra
Sharad Mishra has uploaded a new change for review. Change subject: restapi: WIP: Created restapi interface for backup. .. restapi: WIP: Created restapi interface for backup. This is not fully functional/populated code. The idea

[Engine-patches] Change in ovirt-live[master]: ovirt-live: remove wget sanlock 2.6-7

2013-04-24 Thread mgoldboi
Moran Goldboim has posted comments on this change. Change subject: ovirt-live: remove wget sanlock 2.6-7 .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14121 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-live[master]: ovirt-live: remove wget sanlock 2.6-7

2013-04-24 Thread mgoldboi
Moran Goldboim has submitted this change and it was merged. Change subject: ovirt-live: remove wget sanlock 2.6-7 .. ovirt-live: remove wget sanlock 2.6-7 we used to get this sanlock version from koji due to a bug. now that thi

[Engine-patches] Change in ovirt-engine[master]: frontend: Fix findbugs error in VmListModel class

2013-04-24 Thread derez
Daniel Erez has posted comments on this change. Change subject: frontend: Fix findbugs error in VmListModel class .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14213 T

[Engine-patches] Change in ovirt-engine[master]: core: Rename storage_pool entity to StoragePool

2013-04-24 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Rename storage_pool entity to StoragePool .. Patch Set 1: (3 inline comments) File backend/manager/mod

[Engine-patches] Change in ovirt-engine[master]: packaging: remove uselss file

2013-04-24 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: remove uselss file .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14218 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: packaging: move man pages to own directory

2013-04-24 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: move man pages to own directory .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14217 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: packaging: move man pages to own directory

2013-04-24 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: move man pages to own directory .. packaging: move man pages to own directory Change-Id: Ia107e24c0d0bbf1ceb40916bcaf34111e66b7335 Signed-off-by: Alon

[Engine-patches] Change in ovirt-engine[master]: packaging: remove uselss file

2013-04-24 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: remove uselss file .. packaging: remove uselss file Change-Id: Ibe8c3f67b0c95e7d33b24ccb8da9ed5568c346fa Signed-off-by: Alon Bar-Lev --- D packaging/

[Engine-patches] Change in ovirt-engine[master]: userportal : User has insufficient permissions on url /domai...

2013-04-24 Thread rnori
Ravi Nori has posted comments on this change. Change subject: userportal : User has insufficient permissions on url /domain/domain_id/user .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/14185 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: branding support.

2013-04-24 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: branding support. .. Patch Set 8: Verified Changes in this patchset: * Moved LocaleFilter from root war into utils so it can be shared. *

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-04-24 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 5: (2 inline comments) >Adding watchdog data in vm general subtab >Enabling watchdog fields according to supported >com

[Engine-patches] Change in ovirt-engine[master]: webadmin: Disks and Snapshots sub-tabs resizable columns

2013-04-24 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Disks and Snapshots sub-tabs resizable columns .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14216 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Disks and Snapshots sub-tabs resizable columns

2013-04-24 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: webadmin: Disks and Snapshots sub-tabs resizable columns .. webadmin: Disks and Snapshots sub-tabs resizable columns Disks and Snapshots sub-tabs now support resi

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Improve form-based sub tabs

2013-04-24 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin,userportal: Improve form-based sub tabs .. Patch Set 10: Shouldn't a span/div also auto wrap if the proper styles are applied? -- To view, visit http:

[Engine-patches] Change in ovirt-live[master]: ovirt-live: remove wget sanlock 2.6-7

2013-04-24 Thread dcaroest
David Caro has posted comments on this change. Change subject: ovirt-live: remove wget sanlock 2.6-7 .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14121 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Improve form-based sub tabs

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Improve form-based sub tabs .. Patch Set 10: If I'm not mistaken, with GWT Grid (table HTML element) there will be no need to specify item

[Engine-patches] Change in ovirt-engine[master]: restapi:Correct rsdl for add bricks

2013-04-24 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi:Correct rsdl for add bricks .. Patch Set 1: (2 inline comments) Please see my comments File backend/ma

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Improve form-based sub tabs

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Improve form-based sub tabs .. Patch Set 10: Thanks, I'll try to fix all issues for VMs -> Snapshots -> General sub tab. > - many labels ar

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - DB and logic changes

2013-04-24 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - DB and logic changes .. Patch Set 5: (1 inline comment) File backend/manager/modules/co

[Engine-patches] Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...

2013-04-24 Thread asaf
Asaf Shakarchi has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups .. Patch Set 4: (5 inline comments) Fil

[Engine-patches] Change in ovirt-engine[master]: frontend: Fix findbugs error in VmListModel class

2013-04-24 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: frontend: Fix findbugs error in VmListModel class .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14213 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: frontend: Fix findbug errors in Linq.java

2013-04-24 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: frontend: Fix findbug errors in Linq.java .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14212 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...

2013-04-24 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups .. Patch Set 4: (1 inline comment) File

[Engine-patches] Change in ovirt-engine[master]: webadmin: load image refreshing data

2013-04-24 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: load image refreshing data .. webadmin: load image refreshing data - Fixed when switching main tabs always show 'loading' image so the user ha

[Engine-patches] Change in ovirt-engine[master]: webadmin: load image refreshing data

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: load image refreshing data .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12946 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: webadmin: load image refreshing data

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: load image refreshing data .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12946 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: load image refreshing data

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: load image refreshing data .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/12946 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...

2013-04-24 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups .. Patch Set 4: (1 inline comment) File

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - DB and logic changes

2013-04-24 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: watchdog - DB and logic changes .. Patch Set 5: (1 inline comment) File backend/manager/modules/bll

[Engine-patches] Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...

2013-04-24 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups .. Patch Set 4: (6 inline comments) File

[Engine-patches] Change in ovirt-engine[master]: webadmin: Making network related subtabs resizeable

2013-04-24 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Making network related subtabs resizeable .. webadmin: Making network related subtabs resizeable Fixed sub tabs- - Network Cluster - Network Host - Net

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - DB and logic changes

2013-04-24 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - DB and logic changes .. Patch Set 5: (1 inline comment) File backend/manager/modules/co

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - DB and logic changes

2013-04-24 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - DB and logic changes .. Patch Set 5: (2 inline comments) File backend/manager/modules/b

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - DB and logic changes

2013-04-24 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: watchdog - DB and logic changes .. Patch Set 5: (10 inline comments) File backend/manager/modules/b

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: split service to allow code reuse

2013-04-24 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: split service to allow code reuse .. packaging: engine-service: split service to allow code reuse this will allow to reuse e

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: split service to allow code reuse

2013-04-24 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-service: split service to allow code reuse .. Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1415

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: move generated code out of main s...

2013-04-24 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: move generated code out of main source .. packaging: engine-service: move generated code out of main source this ease maint

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: move generated code out of main s...

2013-04-24 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-service: move generated code out of main source .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: rename service directory to servi...

2013-04-24 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: rename service directory to services .. packaging: engine-service: rename service directory to services we are about to have

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: rename service directory to servi...

2013-04-24 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-service: rename service directory to services .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: move service out of fedora into o...

2013-04-24 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: move service out of fedora into own directory .. packaging: engine-service: move service out of fedora into own directory s

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: move service out of fedora into o...

2013-04-24 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-service: move service out of fedora into own directory .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: split service to allow code reuse

2013-04-24 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-service: split service to allow code reuse .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1415

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: move generated code out of main s...

2013-04-24 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-service: move generated code out of main source .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: rename service directory to servi...

2013-04-24 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-service: rename service directory to services .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-service: move service out of fedora into o...

2013-04-24 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: engine-service: move service out of fedora into own directory .. Patch Set 4: Verified; Looks good to me, approved VERIFIED by abarlev -- To view,

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated running taskcleaner utility

2013-04-24 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated running taskcleaner utility .. packaging: Updated running taskcleaner utility This patch fixes the incomplete patch http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated running taskcleaner utility

2013-04-24 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Updated running taskcleaner utility .. Patch Set 3: Verified Merging based on previous acks and verification. -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated running taskcleaner utility

2013-04-24 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Updated running taskcleaner utility .. Patch Set 3: Looks good to me, approved Merging based on previous acks and verification. -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated running taskcleaner utility

2013-04-24 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Updated running taskcleaner utility .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14095 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: default rpm packaging to build complete feature s...

2013-04-24 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: default rpm packaging to build complete feature set .. packaging: default rpm packaging to build complete feature set executing rpmbuild -tb

[Engine-patches] Change in ovirt-engine[master]: packaging: default rpm packaging to build complete feature s...

2013-04-24 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: default rpm packaging to build complete feature set .. Patch Set 2: Verified; Looks good to me, approved I agree with Alon. (Or more accurate, I don'

[Engine-patches] Change in ovirt-engine[master]: frontend: Fix findbugs error in VmListModel class

2013-04-24 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: frontend: Fix findbugs error in VmListModel class .. frontend: Fix findbugs error in VmListModel class Change-Id: I38b0b40dd4316162440ed40d2947549a63a41b1e Signed-o

[Engine-patches] Change in ovirt-engine[master]: core: Update VM status if host is not available

2013-04-24 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Update VM status if host is not available .. core: Update VM status if host is not available The VM status is set to Unknown if the host is marked

[Engine-patches] Change in ovirt-engine[master]: core: Update VM status if host is not available

2013-04-24 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Update VM status if host is not available .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13706 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: Update VM status if host is not available

2013-04-24 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Update VM status if host is not available .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13706 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotation - do not execute ls on non-existing ...

2013-04-24 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: log rotation - do not execute ls on non-existing files .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotation - do not execute ls on non-existing ...

2013-04-24 Thread knesenko
Kiril Nesenko has posted comments on this change. Change subject: packaging: log rotation - do not execute ls on non-existing files .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: frontend: Fix findbug errors in Linq.java

2013-04-24 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: frontend: Fix findbug errors in Linq.java .. frontend: Fix findbug errors in Linq.java Change-Id: I03d340ffe8286180f907785b998d6bbf3c0e09bd Signed-off-by: Tal Nisan

[Engine-patches] Change in ovirt-engine[master]: core: Rename storage_pool entity to StoragePool

2013-04-24 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Rename storage_pool entity to StoragePool .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14208 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: packaging: log rotation - do not execute ls on non-existing ...

2013-04-24 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: log rotation - do not execute ls on non-existing files .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/14097 To unsubscribe, visi

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: bridge: do not allow multiple same ips for engine

2013-04-24 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsm: bridge: do not allow multiple same ips for engine .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14209 To un

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: bridge: do not allow multiple same ips for engine

2013-04-24 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: do not allow multiple same ips for engine .. vdsm: bridge: do not allow multiple same ips for engine Change-Id: I3fd95e61d1b1a405650f164d54

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: bridge: do not allow multiple same ips for engine

2013-04-24 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: vdsm: bridge: do not allow multiple same ips for engine .. vdsm: bridge: do not allow multiple same ips for engine Change-Id: I3fd95e61d1b1a405650f164d547004151d

[Engine-patches] Change in ovirt-engine[master]: core: Avoid concurrent modification in DirectorySearcher

2013-04-24 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Avoid concurrent modification in DirectorySearcher .. core: Avoid concurrent modification in DirectorySearcher When doing LDAP searches we iterate the li

[Engine-patches] Change in ovirt-engine[master]: webadmin: load image refreshing data

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: load image refreshing data .. Patch Set 3: > Vojtech/Alex - what do you think? Derez has raised an interesting point here: > The patches seem to do pr

[Engine-patches] Change in ovirt-engine[master]: core: i18n splash screen.

2013-04-24 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: core: i18n splash screen. .. core: i18n splash screen. - Added SplashServlet to i18n the splash page. - Added LocaleFilter to automatically detect local

[Engine-patches] Change in ovirt-engine[master]: core: i18n splash screen.

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: core: i18n splash screen. .. Patch Set 7: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12695 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: core: i18n splash screen.

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: core: i18n splash screen. .. Patch Set 7: Rebased (no changes since last time). -- To view, visit http://gerrit.ovirt.org/12695 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: i18n splash screen.

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: core: i18n splash screen. .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12695 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: webadmin: remove table focus.

2013-04-24 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: remove table focus. .. webadmin: remove table focus. - Removed focus from AbstractActionTable when selecting a row. This stops a scroll on ref

[Engine-patches] Change in ovirt-engine[master]: webadmin: remove table focus.

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: remove table focus. .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13981 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: engine: Gluster hook content query

2013-04-24 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: engine: Gluster hook content query .. Patch Set 5: (4 inline comments) File backend/manager/modules/bll/src/m

[Engine-patches] Change in ovirt-engine[master]: webadmin: remove table focus.

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: remove table focus. .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/13981 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: remove table focus.

2013-04-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: remove table focus. .. Patch Set 2: Looks good to me, approved Rebased, just fixed some very minor code formatting stuff. -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - DB and logic changes

2013-04-24 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - DB and logic changes .. Patch Set 5: (1 inline comment) File backend/manager/modules/co

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - DB and logic changes

2013-04-24 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - DB and logic changes .. Patch Set 5: (1 inline comment) File backend/manager/modules/bl

[Engine-patches] Change in ovirt-engine[master]: engine:Fixing findbug error in gluster hooks list

2013-04-24 Thread sanjal
Shireesh Anjal has submitted this change and it was merged. Change subject: engine:Fixing findbug error in gluster hooks list .. engine:Fixing findbug error in gluster hooks list Fixed a findbug error in GlusterHooksListReturnF

  1   2   >