Tal Nisan has uploaded a new change for review. Change subject: frontend: Fix findbug errors in Linq.java ......................................................................
frontend: Fix findbug errors in Linq.java Change-Id: I03d340ffe8286180f907785b998d6bbf3c0e09bd Signed-off-by: Tal Nisan <tni...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 19 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/14212/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java index 0a0276d..92e0831 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java @@ -715,7 +715,7 @@ public static <TSource> boolean All(Iterable<TSource> source, IPredicate<TSource> predicate) { for (TSource item : source) { - if (!predicate.Match(item)) { + if (!predicate.match(item)) { return false; } } @@ -729,7 +729,7 @@ for (TSource item : source) { - if (predicate.Match(item)) + if (predicate.match(item)) { list.add(item); } @@ -755,7 +755,7 @@ { for (TSource item : source) { - if (predicate.Match(item)) + if (predicate.match(item)) { return item; } @@ -1034,7 +1034,7 @@ } @Override - public boolean Match(Map.Entry<String, String> source) + public boolean match(Map.Entry<String, String> source) { return StringHelper.stringsEqual(source.getKey(), timeZone); } @@ -1050,7 +1050,7 @@ } @Override - public boolean Match(ServerCpu source) + public boolean match(ServerCpu source) { return StringHelper.stringsEqual(source.getCpuName(), cpuName); } @@ -1066,7 +1066,7 @@ } @Override - public boolean Match(Version source) + public boolean match(Version source) { return source.equals(version); } @@ -1082,7 +1082,7 @@ } @Override - public boolean Match(storage_pool source) + public boolean match(storage_pool source) { return id.equals(source.getId()); } @@ -1098,7 +1098,7 @@ } @Override - public boolean Match(storage_pool source) + public boolean match(storage_pool source) { return source.getstatus() == status; } @@ -1114,7 +1114,7 @@ } @Override - public boolean Match(storage_pool source) + public boolean match(storage_pool source) { return source.getstatus() != status; } @@ -1124,7 +1124,7 @@ public final static class CanDoActionSucceedPredicate implements IPredicate<VdcReturnValueBase> { @Override - public boolean Match(VdcReturnValueBase source) { + public boolean match(VdcReturnValueBase source) { return source.getCanDoAction(); } } @@ -1139,7 +1139,7 @@ } @Override - public boolean Match(VDSGroup source) + public boolean match(VDSGroup source) { return id.equals(source.getId()); } @@ -1155,7 +1155,7 @@ } @Override - public boolean Match(VDS source) + public boolean match(VDS source) { return source.getId().equals(id); } @@ -1171,7 +1171,7 @@ } @Override - public boolean Match(VDS source) + public boolean match(VDS source) { return source.getStatus().equals(status); } @@ -1187,7 +1187,7 @@ } @Override - public boolean Match(VmTemplate source) + public boolean match(VmTemplate source) { return source.getId().equals(id); } @@ -1203,7 +1203,7 @@ } @Override - public boolean Match(StorageDomain source) + public boolean match(StorageDomain source) { return id.equals(source.getId()); } @@ -1218,7 +1218,7 @@ } @Override - public boolean Match(StorageDomain source) { + public boolean match(StorageDomain source) { return name.equals(source.getStorageName()); } } @@ -1233,7 +1233,7 @@ } @Override - public boolean Match(LunModel source) + public boolean match(LunModel source) { return StringHelper.stringsEqual(source.getLunId(), lun.getLunId()); } @@ -1249,7 +1249,7 @@ } @Override - public boolean Match(SanTargetModel source) + public boolean match(SanTargetModel source) { return StringHelper.stringsEqual(source.getName(), target.getName()) && StringHelper.stringsEqual(source.getAddress(), target.getAddress()) @@ -1259,7 +1259,7 @@ public interface IPredicate<TSource> { - boolean Match(TSource source); + boolean match(TSource source); } -- To view, visit http://gerrit.ovirt.org/14212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I03d340ffe8286180f907785b998d6bbf3c0e09bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches