Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Improve form-based sub tabs ......................................................................
Patch Set 10: Thanks, I'll try to fix all issues for VMs -> Snapshots -> General sub tab. > - many labels are getting cut on other languages (e.g. Japanese - Hosts > General sub-tab) This is a very good point, maybe I should reconsider using GWT Grid for layout purposes (table layout would prevent labels getting cut off), instead of doing same-label-width layout by hand (inside FormBuilder.addFormItem method). Based on [http://gxtvsgwt.appspot.com/], GWT Grid performance shouldn't be an issue for small data (General sub tabs). Thanks for pointing this out, Daniel. -- To view, visit http://gerrit.ovirt.org/12325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b2f2577b1b488d5514dc05c2590a2bb53fcfe4f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
