Gilad Chaplik has posted comments on this change. Change subject: engine: Propagate error message when quering for LDAP users/groups ......................................................................
Patch Set 4: (1 inline comment) .................................................... File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java Line 2253: Line 2254: @DefaultStringValue("Cannot ${action} ${type}. Gluster service is not supported in compatibility version ${compatibilityVersion}.") Line 2255: String GLUSTER_NOT_SUPPORTED(); Line 2256: Line 2257: @Constants.DefaultStringValue("Failed to run LDAP query, please contact the system administrator.") After rethinking, I was wrong, don't think we need to show 'please contact the system administrator' in webadmin's appErrors, only in user portal. Please consult Yair. Line 2258: String FAILED_TO_RUN_LDAP_QUERY(); -- To view, visit http://gerrit.ovirt.org/11893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50da72d12c6d60642ad5e65b9376efc49e4ef699 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches