Laszlo Hornyak has posted comments on this change.

Change subject: engine: watchdog - DB and logic changes
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateWatchdogParameters.java
Line 2: 
Line 3: public class UpdateWatchdogParameters extends VmOperationParameterBase {
Line 4:     private static final long serialVersionUID = 8564973734004518462L;
Line 5:     String action;
Line 6:     String model;
Ok, this can be an enum and in this case there will be no canDoAction in 
UpdateWatchdogCommand
Line 7: 
Line 8:     public String getAction() {
Line 9:         return action;
Line 10:     }


--
To view, visit http://gerrit.ovirt.org/13057
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I813a6f97e23008d15446285998a4e9b50b456040
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to