Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Disks and Snapshots sub-tabs resizable columns
......................................................................
webadmin: Disks and Snapshots sub-tabs resizable columns
Disks and Snapshots sub-tabs now support
resizable columns.
* Invoked enableColumnResizing() on each sub-tab.
* Added a static width value for each column.
Change-Id: Ief60915ae0d7ddbfe5d9cb808756796773478541
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java
2 files changed, 13 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/14216/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java
index 548820d..b9840e4 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java
@@ -72,11 +72,13 @@
getModel().setItems(null);
getModel().search();
+ getTable().enableColumnResizing();
+
getTable().ensureColumnPresent(
DisksViewColumns.diskStatusColumn, constants.empty(), all ||
images || luns, "30px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.aliasColumn, constants.aliasDisk(), all ||
images || luns);
+ DisksViewColumns.aliasColumn, constants.aliasDisk(), all ||
images || luns, "80px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
DisksViewColumns.bootableDiskColumn,
@@ -106,16 +108,16 @@
DisksViewColumns.dateCreatedColumn,
constants.creationDateDisk(), images, "120px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.lunIdColumn, constants.lunIdSanStorage(),
luns);
+ DisksViewColumns.lunIdColumn, constants.lunIdSanStorage(),
luns, "130px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.lunSerialColumn,
constants.serialSanStorage(), luns);
+ DisksViewColumns.lunSerialColumn,
constants.serialSanStorage(), luns, "130px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.lunVendorIdColumn,
constants.vendorIdSanStorage(), luns);
+ DisksViewColumns.lunVendorIdColumn,
constants.vendorIdSanStorage(), luns, "130px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.lunProductIdColumn,
constants.productIdSanStorage(), luns);
+ DisksViewColumns.lunProductIdColumn,
constants.productIdSanStorage(), luns, "130px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
DisksViewColumns.diskContainersColumn,
constants.attachedToDisk(), all || images || luns, "110px"); //$NON-NLS-1$
@@ -127,7 +129,7 @@
DisksViewColumns.statusColumn, constants.statusDisk(), images,
"90px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.descriptionColumn,
constants.descriptionDisk(), all || images || luns);
+ DisksViewColumns.descriptionColumn,
constants.descriptionDisk(), all || images || luns, "130px"); //$NON-NLS-1$
}
}
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java
index 72ea378..7d591f0 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java
@@ -81,6 +81,8 @@
@Override
public void initTable(final CommonApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
TextColumnWithTooltip<Snapshot> dateColumn = new
TextColumnWithTooltip<Snapshot>() {
@Override
public String getValue(Snapshot snapshot) {
@@ -90,7 +92,7 @@
return
FullDateTimeRenderer.getLocalizedDateTimeFormat().format(snapshot.getCreationDate());
}
};
- getTable().addColumn(dateColumn, constants.dateSnapshot());
+ getTable().addColumn(dateColumn, constants.dateSnapshot(), "185px");
//$NON-NLS-1$
TextColumnWithTooltip<Snapshot> statusColumn = new
EnumColumn<Snapshot, SnapshotStatus>() {
@Override
@@ -98,7 +100,7 @@
return snapshot.getStatus();
}
};
- getTable().addColumn(statusColumn, constants.statusSnapshot(),
"100px"); //$NON-NLS-1$
+ getTable().addColumn(statusColumn, constants.statusSnapshot(),
"95px"); //$NON-NLS-1$
SafeHtmlColumn<Snapshot> descriptionColumn = new
SafeHtmlColumn<Snapshot>() {
@Override
@@ -123,7 +125,7 @@
return description;
}
};
- getTable().addColumn(descriptionColumn,
constants.descriptionSnapshot());
+ getTable().addColumn(descriptionColumn,
constants.descriptionSnapshot(), "185px"); //$NON-NLS-1$
initActionButtons(constants);
disableActiveSnapshotRow();
--
To view, visit http://gerrit.ovirt.org/14216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief60915ae0d7ddbfe5d9cb808756796773478541
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
