Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateWatchdogCommand.java
Line 18: }
Line 19:
Line 20: protected void executeVmCommand() {
Line 21: List<VmDevice> watchdogs =
getVmDeviceDao().getVmDeviceByVmIdAndType(getVmId(),
VmDeviceType.WATCHDOG.getName());
Line 22: if(watchdogs.isEmpty()) {
I can add a unit test for that if you want, but tons of other calls to the same
method assume that the returned list is not null. See e.g. VmInfoBuilder.
Line 23: //create new watchdog
Line 24: VmDevice watchdogDevice = new VmDevice();
Line 25: watchdogDevice.setType(VmDeviceType.WATCHDOG.getName());
Line 26: watchdogDevice.setId(new VmDeviceId(Guid.NewGuid(),
getVmId()));
Line 42: specParams.put("model", getParameters().getModel());
Line 43: return specParams;
Line 44: }
Line 45:
Line 46: protected boolean canDoAction() {
Ok, however that sounds like making double-sure :)
Line 47: return true;
Line 48: }
Line 49:
--
To view, visit http://gerrit.ovirt.org/13057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I813a6f97e23008d15446285998a4e9b50b456040
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
