Vojtech Szocs has posted comments on this change. Change subject: webadmin: load image refreshing data ......................................................................
Patch Set 3: > Vojtech/Alex - what do you think? Derez has raised an interesting point here: > The patches seem to do pretty much the same, just with a different > implementation/design: This patch vs. the other one [http://gerrit.ovirt.org/#/c/7493/] have both different UI representations [A] and address different kinds of events occuring in the application [B]. [A] UI representation This patch: CellTable default loading indicator (animated image) Other patch: text box shown in top center of the screen (Gmail-like "Loading" box) [B] Addressed event This patch: CellTable being shown to user (as a result of place transition, i.e. revealing new main tab), *or* user clicking the Refresh button for the CellTable --> the idea is to provide additional feedback with regard to loading table data (scope = specific table) Other patch: transition from one place (e.g. main tab X) to another (e.g. sub tab Y of main tab X) --> the idea is to provide additional feedback with regard to UI as a whole, during place transition any UI interaction should be avoided (scope = entire application) > (1) in this patch, the loading-progress is represented by the > "squares"-animation which is triggered on the relevant tab-related events > (onReveal, onRefresh/ManualRefresh, etc.). Correct, but important thing is the "loading-progress" scoped to a specific table (not entire application). > (2) in http://gerrit.ovirt.org/#/c/7493/, the loading-progress is represented > by "a small text box shown in top center of the screen" which is triggered by > the "LockInteraction" event, fired when "the application is transitioning > from one place to another". Correct, in WebAdmin all main & sub tabs are actually places of the application, and during transition from one place to another, any UI interaction should be avoided. Implementation-wise, GWTP RootPresenter shows invisible "glass" on top of everything to prevent UI interaction, but still the user should have visual feedback about this transition. > One difference that I can think of between (1) and (2) [and I could be wrong] > is that upon manual refresh, the loading-indication in (1) will be triggered, > but not the loading-indication in (2). Correct. > So I agree with Derez on this one - we should probably consider both patches > to be eventually introduced. Me too, I'll go ahead and create usability-related RFE that [http://gerrit.ovirt.org/#/c/7493/] meant to solve. For now, let's proceed with this patch, Alex is right by saying this patch has different scope than the other one. -- To view, visit http://gerrit.ovirt.org/12946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8be80df57eafc4244c57029f8260d4d67c47b3f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
