Daniel Erez has posted comments on this change.
Change subject: frontend: Fix findbug errors in Linq.java
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
Line 711:
Line 712: return null;
Line 713: }
Line 714:
Line 715: public static <TSource> boolean All(Iterable<TSource> source,
IPredicate<TSource> predicate) {
While at it, can you fix also this one..
Line 716:
Line 717: for (TSource item : source) {
Line 718: if (!predicate.match(item)) {
Line 719: return false;
Line 722:
Line 723: return true;
Line 724: }
Line 725:
Line 726: public static <TSource> Iterable<TSource> Where(Iterable<TSource>
source, IPredicate<TSource> predicate)
same
Line 727: {
Line 728: ArrayList<TSource> list = new ArrayList<TSource>();
Line 729:
Line 730: for (TSource item : source)
--
To view, visit http://gerrit.ovirt.org/14212
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03d340ffe8286180f907785b998d6bbf3c0e09bd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
