Kanagaraj M has posted comments on this change.
Change subject: engine: Gluster hook content query
......................................................................
Patch Set 5: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterHookContentQuery.java
Line 26: new
GlusterHookVDSParameters(getParameters().getGlusterServerId(),
Line 27: hook.getGlusterCommand(),
Line 28: hook.getStage(),
Line 29: hook.getName()));
Line 30:
getQueryReturnValue().setReturnValue(returnValue.getReturnValue());
vdsm will return the hook content in base64 encoded format, so we should
decoded it and return.
Line 31: }
Line 32: }
Line 33:
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDao.java
Line 41: public GlusterServerHook getGlusterServerHook(Guid hookId, Guid
serverId);
Line 42:
Line 43: public List<GlusterHookEntity> getByClusterId(Guid clusterId);
Line 44:
Line 45: public String getGlusterHookcontent(Guid glusterHookId);
please rename it to getGlusterHookContent
Line 46:
Line 47: @Override
Line 48: public List<GlusterHookEntity> getAllWithQuery(String query);
Line 49:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHookContentInfoReturnForXmlRpc.java
Line 20:
Line 21: Map<String, Object> content = (Map<String, Object>)
innerMap.get(CONTENT);
Line 22: if (content != null) {
Line 23: hookContent = (String) content.get(0);
Line 24: }
I am not sure it is in sync with the vdsm verb's output structure here
http://gerrit.ovirt.org/#/c/14145/
Line 25: }
Line 26:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
Line 243:
Line 244: StatusOnlyReturnForXmlRpc glusterHookDisable(String
glusterCommand, String stage, String hookName);
Line 245:
Line 246: GlusterHooksListReturnForXmlRpc glusterHooksList();
Line 247:
please remove the empty spaces
Line 248: GlusterHookContentInfoReturnForXmlRpc glusterHookRead(String
glusterCommand, String stage, String hookName);
--
To view, visit http://gerrit.ovirt.org/12219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie24d1132fc214661cd2c2e3071f641812d19cd4f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
