Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup repo_files_meta_data_sp.sql
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4057
To unsubscribe, visit http:/
Moti Asayag has posted comments on this change.
Change subject: new feature: Vm Payload
..
Patch Set 13: (1 inline comment)
File
backend/manager/modules/bll/src/main/java/or
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Gluster Volume Option Entity changed
..
engine: Gluster Volume Option Entity changed
GlusterVolumeOptionEntity equals method is comparing the vol
Omer Frenkel has posted comments on this change.
Change subject: engine: Gluster Volume Option Entity changed
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4038
To unsubscribe, visit http:
Shahar Havivi has posted comments on this change.
Change subject: new feature: Vm Payload
..
Patch Set 12: Verified
(3 inline comments)
File
backend/manager/modules/bll/src
Kanagaraj M has posted comments on this change.
Change subject: engine: Gluster Volume Option Entity changed
..
Patch Set 2: Verified
rebase and verified.
--
To view, visit http://gerrit.ovirt.org/4038
To unsubscribe, visit ht
Kanagaraj M has abandoned this change.
Change subject: webadmin: Gluster Volume Start/Stop enable/disable
..
Patch Set 1: Abandoned
as it is duplicate of
http://gerrit.ovirt.org/#change,3949
--
To view, visit http://gerrit.ov
Danny Rankevich has posted comments on this change.
Change subject: webadmin: manage cluster networks dialog
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3209
To uns
Alex Lourie has posted comments on this change.
Change subject: packaging: Fixed creating app user on postgresql 8.4
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Yair Zaslavsky has posted comments on this change.
Change subject: restapi: Mappers for Gluster entities
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3385
To unsubsc
Moti Asayag has posted comments on this change.
Change subject: new feature: Vm Payload
..
Patch Set 12: (3 inline comments)
File
backend/manager/modules/bll/src/main/java/o
Shireesh Anjal has posted comments on this change.
Change subject: restapi: Mappers for Gluster entities
..
Patch Set 10:
- removed StringHelper from the patch as it was just whitespace
- removed StringUtils#collectionToString
Shireesh Anjal has posted comments on this change.
Change subject: restapi: Mappers for Gluster entities
..
Patch Set 9: (3 inline comments)
File
backend/manager/modules/com
Yair Zaslavsky has posted comments on this change.
Change subject: restapi: Mappers for Gluster entities
..
Patch Set 9: (3 inline comments)
File
backend/manager/modules/com
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal,webadmin: Add missing NON-NLS comments
..
userportal,webadmin: Add missing NON-NLS comments
Added NON-NLS comments to comply with non-externa
Gilad Chaplik has posted comments on this change.
Change subject: userportal,webadmin: Add missing NON-NLS comments
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4034
To unsubscr
Gilad Chaplik has posted comments on this change.
Change subject: userportal,webadmin: Add missing NON-NLS comments
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4034
To unsubscr
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin, engine: reformat pom files
..
webadmin, engine: reformat pom files
This patch reformats some pom files to standard XML using xmllint.
Signed-
Gilad Chaplik has posted comments on this change.
Change subject: webadmin, engine: reformat pom files
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4061
To unsubscribe, visit ht
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: adding externalize check to the frontend checkstyle
..
webadmin: adding externalize check to the frontend checkstyle
no bz
1. Separating buil
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: adding externalize check to the frontend checkstyle
..
Patch Set 18: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/376
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: add missing $NON-NLS comments.
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4059
To unsubscribe, visi
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: add missing $NON-NLS comments.
..
webadmin: add missing $NON-NLS comments.
no bz
Change-Id: I633c199901c2969a225b6964ccd3ab929f621201
Signed-
Yair Zaslavsky has posted comments on this change.
Change subject: engine: getUpServer method moved to new class ClusterUtils
..
Patch Set 1: I would prefer that you didn't submit this
1. Please add Unit-Test to GlusterUtils
2.
Shahar Havivi has posted comments on this change.
Change subject: new feature: Vm Payload
..
Patch Set 12: (16 inline comments)
File
backend/manager/modules/bll/src/main/jav
BUILD SUCCESS
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/719/
Project: ovirt_engine_unit_tests
Date of build: Tue, 01 May 2012 10:57:46 -0400
Build duration: 49 min
CHANGE SET
Revision ab3a99836221809dec16d2673ea73a7d4a20d1a8 by amureini: (core: Made all
the public queries u
Omer Frenkel has posted comments on this change.
Change subject: engine: Gluster Volume Option Entity changed
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4038
To unsubscribe, visit http:
Eli Mesika has posted comments on this change.
Change subject: engine: getUpServer method moved to new class ClusterUtils
..
Patch Set 1:
Since the query bring not all the servers of the system, just the servers of a
specific
BUILD UNSTABLE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/718/
Project: ovirt_engine_unit_tests
Date of build: Tue, 01 May 2012 10:01:47 -0400
Build duration: 55 min
CHANGE SET
Revision 3fb193957d148d7e70ba1265da75b065e3633c87 by tnisan: (core: JAXB
annotations cleanup for c
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix broken ValidateSessionQueryTest
..
core: Fix broken ValidateSessionQueryTest
The test was written in an unstandard way, which caused it to brea
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Made all the public queries user queries
..
core: Made all the public queries user queries
These queries can be run without a valid session, so the
Maor Lipchuk has posted comments on this change.
Change subject: core: Made all the public queries user queries
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3959
To unsubscribe, visit htt
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix broken LdapSearchQueryTest
..
core: Fix broken LdapSearchQueryTest
Test was broken when enabling query permissions mechanism. This fix
changes
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix broken ValidateSessionQueryTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4062
To unsubscribe, visit http://g
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix broken LdapSearchQueryTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4063
To unsubscribe, visit http://gerrit
Moti Asayag has posted comments on this change.
Change subject: new feature: Vm Payload
..
Patch Set 12: (1 inline comment)
Commit Message
Line 12: Change-Id: I4c2820acfa8ec0
Allon Mureinik has posted comments on this change.
Change subject: core: Fix broken LdapSearchQueryTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4063
To unsubscribe, visit http://gerrit.ovirt.org/setti
Allon Mureinik has posted comments on this change.
Change subject: core: Fix broken ValidateSessionQueryTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4062
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has uploaded a new change for review.
Change subject: core: Fix broken ValidateSessionQueryTest
..
core: Fix broken ValidateSessionQueryTest
The test was written in an unstandard way, which caused it to break when
Allon Mureinik has uploaded a new change for review.
Change subject: core: Fix broken LdapSearchQueryTest
..
core: Fix broken LdapSearchQueryTest
Test was broken when enabling query permissions mechanism. This fix
changes the ex
Saggi Mizrahi has posted comments on this change.
Change subject: Add missign storage_format_type arg to
Updatestorage_domain_static
..
Patch Set 6: (1 inline comment)
File
Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup repo_files_meta_data_sp.sql
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4057
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: Removed unused license query types.
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/4056
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: Made all the public queries user queries
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/3959
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup repo_files_meta_data_sp.sql
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/4057
To unsubscribe, visit http://gerrit.ovirt.org/
Moti Asayag has posted comments on this change.
Change subject: new feature: Vm Payload
..
Patch Set 12: (15 inline comments)
File
backend/manager/modules/bll/src/main/java/
BUILD UNSTABLE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/717/
Project: ovirt_engine_unit_tests
Date of build: Tue, 01 May 2012 09:18:56 -0400
Build duration: 42 min
CHANGE SET
Revision 2880847860ef53e35f41ddd90bc7a2ebe8cfecc3 by oourfali: (engine: using
vdsUser new isAdmin
Allon Mureinik has posted comments on this change.
Change subject: core: Made all the public queries user queries
..
Patch Set 4: Verified
rebase
--
To view, visit http://gerrit.ovirt.org/3959
To unsubscribe, visit http://gerr
Tal Nisan has submitted this change and it was merged.
Change subject: core: Converter comments removal
..
core: Converter comments removal
Signed-off-by: Tal Nisan
Change-Id: Iaa9b7d8e6380d90ee2d232d262af154464ef6f12
---
M
b
Tal Nisan has posted comments on this change.
Change subject: core: Converter comments removal
..
Patch Set 2: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerrit.ovirt.org/4051
To unsub
Ori Liel has posted comments on this change.
Change subject: restapi : Changes due to change model at engine part
..
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
Tal Nisan has submitted this change and it was merged.
Change subject: core: JAXB annotations cleanup for common module - action
..
core: JAXB annotations cleanup for common module - action
Signed-off-by: Tal Nisan
Change-Id:
Tal Nisan has posted comments on this change.
Change subject: core: JAXB annotations cleanup for common module - action
..
Patch Set 2: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerri
Doron Fediuck has posted comments on this change.
Change subject: engine-core: use javax.servlet api 2.4
..
Patch Set 2:
Is this still relevant?
--
To view, visit http://gerrit.ovirt.org/877
To unsubscribe, visit http://gerrit
Tal Nisan has submitted this change and it was merged.
Change subject: core: JAXB annotations cleanup for common module - errors
..
core: JAXB annotations cleanup for common module - errors
Signed-off-by: Tal Nisan
Change-Id:
Tal Nisan has posted comments on this change.
Change subject: core: JAXB annotations cleanup for common module - errors
..
Patch Set 2: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerri
Omer Frenkel has posted comments on this change.
Change subject: core: Converter comments removal
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4051
To unsubscribe, visit http://
Omer Frenkel has posted comments on this change.
Change subject: core: JAXB annotations cleanup for common module - action
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4050
To unsubscribe
Tal Nisan has submitted this change and it was merged.
Change subject: core: JAXB annotations cleanup for common modules -
businessentities
..
core: JAXB annotations cleanup for common modules - businessentities
Signed-off-by:
Tal Nisan has posted comments on this change.
Change subject: core: JAXB annotations cleanup for common modules -
businessentities
..
Patch Set 2: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit
Doron Fediuck has posted comments on this change.
Change subject: webadmin: adding externalize check to the frontend checkstyle
..
Patch Set 17: Looks good to me, but someone else must approve
Ack based on the next patch, refor
Tal Nisan has submitted this change and it was merged.
Change subject: core: JAXB annotations cleanup for common module - queries
..
core: JAXB annotations cleanup for common module - queries
Signed-off-by: Tal Nisan
Change-Id
Tal Nisan has posted comments on this change.
Change subject: core: JAXB annotations cleanup for common module - queries
..
Patch Set 2: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerr
Doron Fediuck has posted comments on this change.
Change subject: webadmin, engine: reformat pom files
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4061
To unsubscribe, visit ht
BUILD UNSTABLE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/716/
Project: ovirt_engine_unit_tests
Date of build: Tue, 01 May 2012 08:30:05 -0400
Build duration: 41 min
CHANGE SET
No changes
JUNIT RESULTS
Name: org.ovirt.engine.api.common.invocation Failed: 0 test(s),
Allon Mureinik has posted comments on this change.
Change subject: engine: getUpServer method moved to new class ClusterUtils
..
Patch Set 1:
+1 for moving the method to ClusterUtils, but I have some concerned on the
content o
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: using vdsUser new isAdmin method instead of MLA
..
engine: using vdsUser new isAdmin method instead of MLA
This patch uses the vdcUser isAdmin me
Oved Ourfali has posted comments on this change.
Change subject: engine: using vdsUser new isAdmin method instead of MLA
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4060
To uns
Yair Zaslavsky has posted comments on this change.
Change subject: engine: using vdsUser new isAdmin method instead of MLA
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4060
To unsubscribe
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin, engine: reformat pom files
..
webadmin, engine: reformat pom files
This patch reformats some pom files to standard XML using xmllint.
Signed-off-by: A
Omer Frenkel has posted comments on this change.
Change subject: core: JAXB annotations cleanup for common modules -
businessentities
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4049
To
Allon Mureinik has posted comments on this change.
Change subject: engine: using vdsUser new isAdmin method instead of MLA
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
BUILD UNSTABLE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/715/
Project: ovirt_engine_unit_tests
Date of build: Tue, 01 May 2012 07:36:46 -0400
Build duration: 53 min
CHANGE SET
Revision 0912f71a242915a9fd6043bb46b08be3e93fa503 by amureini: (core: User
Queries)
change: edit
Oved Ourfali has uploaded a new change for review.
Change subject: engine: using vdsUser new isAdmin method instead of MLA
..
engine: using vdsUser new isAdmin method instead of MLA
This patch uses the vdcUser isAdmin method in
Doron Fediuck has posted comments on this change.
Change subject: webadmin: adding externalize check to the frontend checkstyle
..
Patch Set 15: (6 inline comments)
Alona,
please add a patch on the same branch to fix indentatio
Alex Lourie has posted comments on this change.
Change subject: packaging: Fixed creating app user on postgresql 8.4
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: add missing $NON-NLS comments.
..
webadmin: add missing $NON-NLS comments.
no bz
Change-Id: I633c199901c2969a225b6964ccd3ab929f621201
Signed-off-by: A
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: vds_installer fix
..
engine: vds_installer fix
Previous commit changed the option from "-v" to "-V" in the
VdsInstaller.java file, but a change i
Oved Ourfali has posted comments on this change.
Change subject: engine: vds_installer fix
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4053
To unsubscribe, visit http://gerrit.
Oved Ourfali has posted comments on this change.
Change subject: engine: vds_installer fix
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/4053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Oved Ourfali has posted comments on this change.
Change subject: engine: vds_installer fix
..
--
To view, visit http://gerrit.ovirt.org/4053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
G
Alona Kaplan has posted comments on this change.
Change subject: webadmin: default values to appErrors
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4054
To
Oved Ourfali has posted comments on this change.
Change subject: engine: vds_installer fix
..
--
To view, visit http://gerrit.ovirt.org/4053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
G
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Query auth by session-cached admin-status
..
core: Query auth by session-cached admin-status
Continuing the effort on uer queries, this patch is
Yair Zaslavsky has posted comments on this change.
Change subject: core: Query auth by session-cached admin-status
..
--
To view, visit http://gerrit.ovirt.org/3957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Login Commands - add admin flag to VdcUser
..
core: Login Commands - add admin flag to VdcUser
The login base command will now update the isAdmin
Yair Zaslavsky has posted comments on this change.
Change subject: core: Login Commands - add admin flag to VdcUser
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3956
To unsubscr
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Login comands - clean up authenticateUser
..
core: Login comands - clean up authenticateUser
Cleaned up isUserCanBeAuthenticated and Authenticate
Yair Zaslavsky has posted comments on this change.
Change subject: core: Login comands - clean up authenticateUser
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3955
To unsubscri
Yair Zaslavsky has posted comments on this change.
Change subject: core: Query auth by session-cached admin-status
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3957
To unsubscribe, visit
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Fixed creating app user on postgresql 8.4
..
Patch Set 1: (2 inline comments)
File backend/manag
Michael Kublin has submitted this change and it was merged.
Change subject: core: QueriesCommandBase rename type to queryType
..
core: QueriesCommandBase rename type to queryType
The new name is more readable, and makes some of
Michael Kublin has submitted this change and it was merged.
Change subject: core: User Queries
..
core: User Queries
Fixed permission checking for queries to disallow running an admin query
with the isFiltered=true flag.
Chang
Michael Kublin has submitted this change and it was merged.
Change subject: core: SessionDataContainer: added setUser method
..
core: SessionDataContainer: added setUser method
This patch introduces the setUser(session,user) an
Michael Kublin has submitted this change and it was merged.
Change subject: core: Cleanup login commands
..
core: Cleanup login commands
Performed some general java and grammer clean ups.
Change-Id: I12ba5479c39d700ecde0276027
Michael Kublin has submitted this change and it was merged.
Change subject: core: Added VdcUser.isAdmin()
..
core: Added VdcUser.isAdmin()
The property was added for future use (i.e., next patches) in the user
query mechanism.
Michael Kublin has posted comments on this change.
Change subject: core: User Queries
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3519
To unsubscribe, visit http://gerrit.ovirt.org/setti
Michael Kublin has posted comments on this change.
Change subject: core: QueriesCommandBase rename type to queryType
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3951
To unsubscribe, visi
Michael Kublin has posted comments on this change.
Change subject: core: Added VdcUser.isAdmin()
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3952
To unsubscribe, visit http://gerrit.ovir
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup login commands
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3954
To unsubscribe, visit http://ge
1 - 100 of 176 matches
Mail list logo
