Eli Mesika has posted comments on this change. Change subject: engine: getUpServer method moved to new class ClusterUtils ......................................................................
Patch Set 1: Since the query bring not all the servers of the system, just the servers of a specific cluster, I think that the provided patch is OK. I agree that if the query was heavier and deals with thousands of records to switch to Allon's solution but today in normal cluster we have much fewer hosts I see also that this is called in relatively low used scenarios : Create/Reset/Set?start/Stop GlusterVolumeCommand , so 1) reasonable expected result set and 2) low frequency leads to my recommendation to leave patch as is. -- To view, visit http://gerrit.ovirt.org/4040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20ec09d3fab39b8cd6d76e8c4c6c00f3ebb44b63 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
