Yair Zaslavsky has posted comments on this change.
Change subject: restapi: Mappers for Gluster entities
......................................................................
Patch Set 9: (3 inline comments)
....................................................
File
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java
Line 3:
Not sure what is the change here.
If no change besides some whitespace issues - remove it from the patch.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/StringUtils.java
Line 203: public static <T> String collectionToString(Collection<T>
collection, String delimiter) {
Please consider using org.apache.commons.lang.StringUtils.join
....................................................
File
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/StringUtilsTest.java
Line 168: public void testCollectionToString() {
Good that you added a test.
However, see my previous comment.
--
To view, visit http://gerrit.ovirt.org/3385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I364d853106eda1a956241eb7210ce85781ee88b9
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Eoghan Glynn <eoghan.gl...@gmail.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
