Doron Fediuck has posted comments on this change. Change subject: webadmin: adding externalize check to the frontend checkstyle ......................................................................
Patch Set 15: (6 inline comments) Alona, please add a patch on the same branch to fix indentations using xmllint. Also, there are some other inline comments. Last thing- no need to rename build-tools /folder/. Just the artifact ID, and below folder names if needed. .................................................... File build-tools-root/ovirt-checkstyle-extension/pom.xml Line 11: <description>Extension to add checks the aren't built-in the checkstyle</description> the aren't? Try: Extending the built-in checkstyle validations with additional validations. .................................................... File frontend/webadmin/modules/frontend/pom.xml Line 100: </configuration> grrrrr.... Please replace tabs with spaces & fix indentation. Try xmllint... .................................................... File frontend/webadmin/modules/gwt-common/pom.xml Line 158: </configuration> Please fix using xmllint. .................................................... File frontend/webadmin/modules/uicommonweb/pom.xml Line 61: </configuration> Please fix using xmllint .................................................... File frontend/webadmin/modules/userportal-gwtp/pom.xml Line 260: </configuration> Please fix using xmllint .................................................... File frontend/webadmin/modules/webadmin/pom.xml Line 259: <propertyExpansion>runNlsCheck=true</propertyExpansion> Please fix using xmllint -- To view, visit http://gerrit.ovirt.org/3760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23035701398158b70b61c1c85a7f6eb40770784 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
