Yair Zaslavsky has posted comments on this change. Change subject: engine: getUpServer method moved to new class ClusterUtils ......................................................................
Patch Set 1: I would prefer that you didn't submit this 1. Please add Unit-Test to GlusterUtils 2. I would recommend GlusterUtils will not contain static methods. I am fully aware of the usage of static methods in "helper classes". However, this will require static mocking with PowerMock, and we want to get rid of that framework. I recommend you see SnapshotsManager as reference. 3. In addition, please do not use a direct call to DbFacade.getInstance.getVdsDao, but extract a method of VdsDAO get VdsDao() (you will then use Mockito in your tests and will be able to use this non static method and change its behavior to return a mocked VdsDao). -- To view, visit http://gerrit.ovirt.org/4040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20ec09d3fab39b8cd6d76e8c4c6c00f3ebb44b63 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
