Moti Asayag has posted comments on this change.
Change subject: new feature: Vm Payload
......................................................................
Patch Set 12: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 315:
getParameters().getVmStaticData().getVmPayload().setContent(Base64.encodeBase64String(
i'm aware of that, we will use the vm payload for 3.1 cluster sysprep.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java
Line 11: public class VmPayload implements Serializable {
using eclipse - the name of the class will be marked with a yellow underline
(state there is eclipse warning). By clicking ctrl+1 a proposal dialogue will
be open with 2 options:
1. add default serialization id
2. generate serialization id
You should select the option to generate serialization id
It is used to identify the class when it is being serialized or deserialized.
search for serialVersionUID in
http://docs.oracle.com/javase/6/docs/api/java/io/Serializable.html
....................................................
Commit Message
Line 12: Change-Id: I4c2820acfa8ec0f736e5fe0ce192e84df0915f12
not "acked-by", rather "Signed-off-by".
see http://lists.ovirt.org/pipermail/infra/2012-April/000339.html
--
To view, visit http://gerrit.ovirt.org/3243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2820acfa8ec0f736e5fe0ce192e84df0915f12
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
