Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Login comands - clean up authenticateUser ......................................................................
core: Login comands - clean up authenticateUser Cleaned up isUserCanBeAuthenticated and AuthenticateUser methods. These methods used two RefObjects (isAdmin and isLocalBackend), which were set to false at creation, and then never updated. This these are variables are simply useless, and do nothing but uglify the code, they were removed. In case they are needed in some future usecase, they can always be added back. Change-Id: Iaa73c8399b84f39f27c4a1c24a587f782664cd91 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginUserCommand.java 2 files changed, 15 insertions(+), 23 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa73c8399b84f39f27c4a1c24a587f782664cd91 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
