Allon Mureinik has posted comments on this change. Change subject: engine: getUpServer method moved to new class ClusterUtils ......................................................................
Patch Set 1: +1 for moving the method to ClusterUtils, but I have some concerned on the content of the method itself. What you're doing is bringing ALL the servers that are up, and then choosing one of them in memory. For enterprise customers, there can be a large number of servers, and this operation will be redundantly heavy. I'd suggest we move this logic to the database: SELECT * FROM vds WHERE status = v_status AND vds_group_id = v_vds_group_id ORDER BY radnom() LIMIT 1 Adding emessika as a reviewer - to get his thoughts on the database implementation. -- To view, visit http://gerrit.ovirt.org/4040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20ec09d3fab39b8cd6d76e8c4c6c00f3ebb44b63 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
