Gilad Chaplik has submitted this change and it was merged. Change subject: userportal,webadmin: Add missing NON-NLS comments ......................................................................
userportal,webadmin: Add missing NON-NLS comments Added NON-NLS comments to comply with non-externalized string convention. Removed unnecessary methods in UserPortal's constants interface. Note: Java sources generated by annotation processors (target/generated-sources/annotations) should be excluded from NON-NLS checks. Signed-off-by: Gilad Chaplik <gchap...@redhat.com> Change-Id: Ic4278a13cabe1710d4eb1ce2ee92714ba6876305 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/ToStringEntityModelLabel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java 4 files changed, 14 insertions(+), 48 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4278a13cabe1710d4eb1ce2ee92714ba6876305 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
