Ori Liel has posted comments on this change. Change subject: restapi : Changes due to change model at engine part ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (2 inline comments) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java Line 132: DiskImage diskImageFromConfig = imagesFromConfiguration.get(asGuid(disk.getImageId())); so working until now with ids was a bug? or maybe simply the disk-id was always equals to image-id? Anyway, please verify that this change doesn't break anything. Line 181: DiskImage templateDisk = templatesDisksMap.get(asGuid(disk.getImageId())); Same comment about disk id VS image id (just verify that it works) -- To view, visit http://gerrit.ovirt.org/3866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19ec6090a7ece513c4069b8d182894c476c8ddf7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
