E-CREATION
kmymoney/widgets/ktreewidgetfilterlinewidget.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121803/diff/
Testing
---
Opened with english local and tested shortcut. Works fine.
Thanks,
Christian David
___
KMyMoney-devel maili
https://bugs.kde.org/show_bug.cgi?id=338296
Christian David changed:
What|Removed |Added
Latest Commit||http://commits.kde.org/kmym
b8926939c9
kmymoney/widgets/ktreewidgetfilterlinewidget.h PRE-CREATION
kmymoney/widgets/ktreewidgetfilterlinewidget.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121803/diff/
Testing
---
Opened with english local and tested shortcut. Works fi
https://bugs.kde.org/show_bug.cgi?id=338296
Christian David changed:
What|Removed |Added
Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
https://bugs.kde.org/show_bug.cgi?id=341552
Christian David changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
CC
> On Nov. 29, 2014, 10:33 vorm., Christian David wrote:
> > kmymoney/mymoney/storage/mymoneystoragesql.cpp, line 740
> > <https://git.reviewboard.kde.org/r/121288/diff/1/?file=331058#file331058line740>
> >
> > This is still an open issue: ```m_storage->fi
https://bugs.kde.org/show_bug.cgi?id=341304
--- Comment #1 from Christian David ---
Git commit d30be72a46be9450a0f205d7c615b96f34a8bf0a by Christian Dávid.
Committed on 10/01/2015 at 16:20.
Pushed by christiand into branch 'master'.
Database version is set after creating tables
So t
p(106)]
Thanks,
Christian David
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
https://bugs.kde.org/show_bug.cgi?id=342952
Christian David changed:
What|Removed |Added
Ever confirmed|0 |1
Severity|normal
https://bugs.kde.org/show_bug.cgi?id=342926
Christian David changed:
What|Removed |Added
Version Fixed In||4.7.2
CC
ust me appended to the string directly :(.
Well done, this task was difficult! Your code — C++ and SQL — looks very fine.
For all developers: Currently I am writing a test. Then we can replace nearly
all ```getRecCount()``` calls with this function and many issues are gone :)
- Christian David
On J
ote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122138/
> ---
>
> (Updated Jan. 19, 2015, 6:02 vorm.)
; as integer)``` -> 0) as well.
Since GCI is over I can take over this task if you want.
- Christian David
On Jan. 20, 2015, 8:59 vorm., Daniel Ring wrote:
>
> ---
> This is an automatically
> On Jan. 20, 2015, 5:12 nachm., Christian David wrote:
> > On my system the test fails as well, seems to be the same issue as before.
> > This solved it:
> >
> > q.prepare(QString("SELECT MAX(CAST(SUBSTR(%1, :prefixLength) AS INTEGER))
> >
l see it has a child for each
supported RDMBS. During the start of the connection the right version is stored
in ```MyMoneyStorageSql::m_driver```.
- Christian David
On Jan. 21, 2015, 9:35 vorm., Daniel Ring wrote:
>
> ---
&
we should init the higest id
vars (```m_{institution,account,…}s```) *once* with the new function. Or simply
the first time a new id is requested - then we can drop nearly all columns of
the table kmmFileInfo - any comments?
- Christian David
On Jan. 24, 2015, 5:59 nachm., Daniel Ring wrote
Jan. 19, 2015, 4:42 nachm.)
>
>
> Review request for KMymoney and Christian David.
>
>
> Repository: kmymoney
>
>
> Description
> ---
>
> Feeds data to an SQLite Database from an excel file
>
>
> Diffs
> -
>
> kmymoney/
https://bugs.kde.org/show_bug.cgi?id=339103
Christian David changed:
What|Removed |Added
Version Fixed In||4.8
Resolution
https://bugs.kde.org/show_bug.cgi?id=339103
--- Comment #14 from Christian David ---
The changes are more than just a bug fix. Back-porting them might be not so
easy (definitely more than some cherry-picks). I think we should streamline our
power to release 4.8 in near future instead.
--
You
which commit is it based?
- Christian David
On Feb. 1, 2015, 3:04 nachm., Allan Anderson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
> On Feb. 1, 2015, 6:13 nachm., Christian David wrote:
> > I cannot apply you patch because of this error:
> >
> > error: patch failed: kmymoney/plugins/csvimport/csvdialog.h:501
> > error: kmymoney/plugins/csvimport/csvdialog.h: patch does not apply
https://bugs.kde.org/show_bug.cgi?id=133364
Christian David changed:
What|Removed |Added
CC||s...@gmx.at
--- Comment #5 from Christian
https://bugs.kde.org/show_bug.cgi?id=185571
Christian David changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution
13.2.
libalkimia/alkvalue.h
<https://git.reviewboard.kde.org/r/122441/#comment52270>
Can you add
/** @todo When gmp version is higer than 5.1.3, remove cstddef include */
for me.
- Christian David
On Feb. 5, 2015, 3:28 nachm., Heiko Becker
> On Feb. 7, 2015, 1:28 nachm., Christian David wrote:
> > libalkimia/alkvalue.h, line 23
> > <https://git.reviewboard.kde.org/r/122441/diff/1/?file=347156#file347156line23>
> >
> > Can you add
> >
> > /** @todo When gmp versio
https://bugs.kde.org/show_bug.cgi?id=343881
Christian David changed:
What|Removed |Added
Resolution|--- |INVALID
Status|UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=344013
Bug ID: 344013
Summary: Icons on home screen are not shown
Product: kmymoney4
Version: git master
Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
Severi
https://bugs.kde.org/show_bug.cgi?id=344013
--- Comment #1 from Christian David ---
Created attachment 91012
--> https://bugs.kde.org/attachment.cgi?id=91012&action=edit
Screenshot of error
--
You are receiving this mail because:
You are the assignee for
ney/views/konlinejoboutbox.cpp a05821a924d0b4e75864cdd2981859c88284c89a
Diff: https://git.reviewboard.kde.org/r/122545/diff/
Testing
---
Manual test of new Ui, ```make test```
Thanks,
Christian David
___
KMyMoney-devel mailing lis
340656.patch
<https://git.reviewboard.kde.org//r/122364/#fcomment314>
This method looks very similar to the following ```…ColumnSelected()```
methods. They could be compacted with some template magic.
File Attachment: Updated patch - 0002-BUG-340656.patch
<https://git.reviewboard.kde
> On Feb. 12, 2015, 10:24 nachm., Christian David wrote:
> > That is a really huge diff. Here are some things I noticed while skimed
> > through it.
> >
> > It seems you reduced the code; very good!
It compiles
4e8c1bdc01af
kmymoney/views/konlinejoboutbox.h 6dc52685f30ad7b6deb8f8db95ff7ff2906f6921
kmymoney/views/konlinejoboutbox.cpp a05821a924d0b4e75864cdd2981859c88284c89a
Diff: https://git.reviewboard.kde.org/r/122545/diff/
Testing
---
Manual test of new Ui, ```make test
https://bugs.kde.org/show_bug.cgi?id=344324
Christian David changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
CC
https://bugs.kde.org/show_bug.cgi?id=344330
Bug ID: 344330
Summary: Password is send several times even if it is wrong
Product: kmymoney4
Version: git master
Platform: unspecified
OS: Linux
Status: UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=342952
Christian David changed:
What|Removed |Added
Resolution|--- |FIXED
Version Fixed In
https://bugs.kde.org/show_bug.cgi?id=342952
Christian David changed:
What|Removed |Added
Resolution|--- |FIXED
Version Fixed In
https://bugs.kde.org/show_bug.cgi?id=344324
Christian David changed:
What|Removed |Added
Version|4.7.1 |git master
Platform|MS Windows
https://bugs.kde.org/show_bug.cgi?id=344324
--- Comment #5 from Christian David ---
I changed this to a wishlist item. Before we start to code we should contact
the VDG. But maybe it is enough to set a tool-tip for the OK button.
--
You are receiving this mail because:
You are the assignee for
https://bugs.kde.org/show_bug.cgi?id=344409
Bug ID: 344409
Summary: User is asked to create a new category in splits table
if change is aborted
Product: kmymoney4
Version: git master
Platform: Compiled Sources
https://bugs.kde.org/show_bug.cgi?id=344412
Christian David changed:
What|Removed |Added
Assignee|kmymoney-devel@kde.org |christian-da...@web.de
CC
https://bugs.kde.org/show_bug.cgi?id=344412
Christian David changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0
https://bugs.kde.org/show_bug.cgi?id=344412
Christian David changed:
What|Removed |Added
Latest Commit||http://commits.kde.org/kmym
https://bugs.kde.org/show_bug.cgi?id=344412
--- Comment #5 from Christian David ---
(In reply to allan from comment #3)
> Anyway, to cut a long sorry story short, I cannot reproduce these problems
> today.
> I also wiped my first PC and all now is sweetness and light.
>
> I&#x
> On Feb. 12, 2015, 10:24 nachm., Christian David wrote:
> > File Attachment: Updated patch - 0002-BUG-340656.patch
> > <https://git.reviewboard.kde.org/r/122364/#fcomment346>
> >
> > This is more a general annotation:
> >
> > You are
> On Feb. 12, 2015, 10:24 nachm., Christian David wrote:
> > File Attachment: Updated patch - 0002-BUG-340656.patch
> > <https://git.reviewboard.kde.org/r/122364/#fcomment397>
> >
> > I do not understand this: "…if only one value column…"
>
https://bugs.kde.org/show_bug.cgi?id=347685
Bug ID: 347685
Summary: Transaction contain erroneous *** UNASSIGNED *** in
Tags view if no payee is given
Product: kmymoney4
Version: git master
Platform: unspecified
-
Thanks,
Christian David
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
://git.reviewboard.kde.org/r/123782/#review80319
---
On Mai 13, 2015, 10:39 nachm., Christian David wrote:
>
> ---
> This is an automatically generated e-mail. To
op
Diff: https://git.reviewboard.kde.org/r/123782/diff/
Testing
---
Thanks,
Christian David
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
https://bugs.kde.org/show_bug.cgi?id=347685
Christian David changed:
What|Removed |Added
Summary|Transaction contain |Transaction contains
https://bugs.kde.org/show_bug.cgi?id=347685
--- Comment #5 from Christian David ---
Created attachment 92661
--> https://bugs.kde.org/attachment.cgi?id=92661&action=edit
Screenshot with the error
Here is a screenshot of the issue, build with d4065b9.
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=347685
--- Comment #6 from Christian David ---
Created attachment 92662
--> https://bugs.kde.org/attachment.cgi?id=92662&action=edit
How I created the transaction
"Spenden" is the category.
--
You are receiving this mail because:
You are
ll to work correctly.
- Christian
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123782/#review80453
---
On Mai 14, 2015, 10:49 vorm., C
ey/plugins/CMakeLists.txt 1a43470fc5ef7a365df9d266a5256f5d7638058a
kmymoney/plugins/kmymoneyimporterplugin.desktop
kmymoney/plugins/kmymoneyplugin.desktop
Diff: https://git.reviewboard.kde.org/r/123782/diff/
Testing
---
Thanks,
Chris
https://bugs.kde.org/show_bug.cgi?id=348492
Christian David changed:
What|Removed |Added
CC||christian-da...@web.de
Resolution
https://bugs.kde.org/show_bug.cgi?id=344013
Christian David changed:
What|Removed |Added
CC||sigma...@gmail.com
--- Comment #7 from
https://bugs.kde.org/show_bug.cgi?id=344013
--- Comment #9 from Christian David ---
(In reply to Dimitrios Glentadakis from comment #6)
> It is ok after disabling the adblock filter in konqueror
I didn't try to disable adblock but I am sure this is not the issue. Maybe
there was anothe
https://bugs.kde.org/show_bug.cgi?id=344013
Christian David changed:
What|Removed |Added
Ever confirmed|0 |1
Status|UNCONFIRMED
c7aea1896f776a9dea105ff388d6058a612d4961
Diff: https://git.reviewboard.kde.org/r/124035/diff/
Testing
---
Thanks,
Christian David
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
,
Christian David
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
https://bugs.kde.org/show_bug.cgi?id=349670
Bug ID: 349670
Summary: "Database not empty" warning is always shown for
SQLite
Product: kmymoney4
Version: git master
Platform: Compiled Sources
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=344013
Christian David changed:
What|Removed |Added
Assignee|kmymoney-devel@kde.org |christian-da...@web.de
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=349684
--- Comment #1 from Christian David ---
Git commit 7c73d6f78dea63279abbd50714b58d372e3ec3ea by Christian Dávid.
Committed on 28/06/2015 at 15:46.
Pushed by christiand into branch 'master'.
Prevent potential use after free
Maybe there is a
https://bugs.kde.org/show_bug.cgi?id=349684
--- Comment #2 from Christian David ---
Do you have an idea why I could not reproduce this issues?
--
You are receiving this mail because:
You are the assignee for the bug.
___
KMyMoney-devel mailing list
https://bugs.kde.org/show_bug.cgi?id=351892
Christian David changed:
What|Removed |Added
Resolution|--- |WAITINGFORINFO
CC
https://bugs.kde.org/show_bug.cgi?id=352029
Bug ID: 352029
Summary: Tag not shown in ledger if only an category is set
Product: kmymoney4
Version: git master
Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=353555
Christian David changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0
> On Dez. 28, 2015, 1:44 vorm., Jeremy Whiting wrote:
> > Makes sense to me.
I'll try it as soon as possible (will probably take until next year). Just a
note: the hole QML script will fail in Qt5 - need to port it first.
- Christian
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126536/#review90892
---
Ship it!
Ship It!
- Christian David
On Dez. 27, 2015, 4
you use KIOs
webdav://, fish:// or ftp://)? I think it will stop working then.
- Christian David
On Jan. 10, 2016, 7:44 p.m., Valentin Rusu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
Hi Everybody,
as Google Code In task I ask a student to fully port our icons to the new scheme. There I noticed that we have no scalable versions of KMyMoney’s icon in the repository. Where is that stored? Is it correct that the icons of different sizes are created manually?
Greetings
Chri
d.kde.org/r/126875/#comment62547>
Translated strings should not be combined, as it confuses the translators.
It is better to create two long strings using i18np() although this duplicates
the text (which is usually bad).
- Christian David
On Jan. 24, 2016, 9:52 nachm., Artur
> On Jan. 24, 2016, 10:02 nachm., Christian David wrote:
> > kmymoney/converter/mymoneystatementreader.cpp, line 1458
> > <https://git.reviewboard.kde.org/r/126875/diff/1/?file=439594#file439594line1458>
> >
> > Translated strings should not be combined, as
d your patch at the moment.
kmymoney/converter/webpricequote.cpp (line 154)
<https://git.reviewboard.kde.org/r/126882/#comment62584>
That is a nice trick to create a temporary file!
- Christian David
On Jan. 25, 2016, 3:56 nach
ps://git.reviewboard.kde.org/r/126875/
> ---
>
> (Updated Jan. 24, 2016, 11:07 nachm.)
>
>
> Review request for KMymoney and Christian David.
>
>
> Repository: kmymoney
>
>
> Description
> ---
>
> Moved the question from `TransactionMatcher:
> Szőts Ákos hat am 24. Januar 2016 um 10:15
> geschrieben:
>
> If the current state of the KF5 branch of KMyMoney is just „needed for
> testing”, I'll gladly help reporting possible bugs. Otherwise you may
> find the
> following porting scripts useful:
> - https://quickgit.kde.org/?p=kde-dev-s
> On Jan. 24, 2016, 10:02 p.m., Christian David wrote:
> > kmymoney/converter/mymoneystatementreader.cpp, line 1458
> > <https://git.reviewboard.kde.org/r/126875/diff/1/?file=439594#file439594line1458>
> >
> > Translated strings should not be combined, as it
erated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126882/
> ---
>
> (Updated Feb. 11, 2016, 10:45 p.m.)
>
>
> Review request for KMymoney and Christian David.
>
>
> Bugs: 275004
>
econd.
- Christian David
On Feb. 13, 2016, 3:54 p.m., Frederik Schwarzer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
, uncompressed and anonymous
format. I could not test the GPG part because none of my keys is currently
shown by the save dialog.
Thanks,
Christian David
cause that should not compile with
Qt 5 and KF 5 at all.
Also I am suprised that setting ```setLocale(QLocale::c());``` works here.
- Christian David
On Feb. 4, 2016, 3:20 p.m., Alexey Chernov wrote:
>
> ---
> This is an automatical
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126875/#review92712
---
Ship it!
Ship It!
- Christian David
On Jan. 24, 2016
-
On Jan. 24, 2016, 11:07 p.m., Artur Puzio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126875/
> ---
>
> (Up
> On Jan. 24, 2016, 10:02 p.m., Christian David wrote:
> > kmymoney/converter/mymoneystatementreader.cpp, line 1458
> > <https://git.reviewboard.kde.org/r/126875/diff/1/?file=439594#file439594line1458>
> >
> > Translated strings should not be combined, as it
complicated than needed. The
request looks fine to me. Do you have the right to push the changes?
- Christian David
On Feb. 24, 2016, 12:11 p.m., Alexey Chernov wrote:
>
> ---
> This is an automatically generated e-mail. To rep
> On Jan. 24, 2016, 10:02 p.m., Christian David wrote:
> > kmymoney/converter/mymoneystatementreader.cpp, line 1458
> > <https://git.reviewboard.kde.org/r/126875/diff/1/?file=439594#file439594line1458>
> >
> > Translated strings should not be combined, as it
)
---
I saved a file several times using the compressed, uncompressed and anonymous
format. I could not test the GPG part because none of my keys is currently
shown by the save dialog.
New: I tested it with GPG encrypted files.
Thanks,
Christian David
bkgpgfile/kgpgfile.cpp
<https://git.reviewboard.kde.org/r/127108/#comment63453>
I removed this test because ```QFile::open()``` will check that anyway and
more important: This can be wrong under some circumstances.
- Christian David
On March 1, 2016, 8:03
> On March 1, 2016, 8:16 p.m., Christian David wrote:
> > libkgpgfile/kgpgfile.cpp, line 162
> > <https://git.reviewboard.kde.org/r/127108/diff/2/?file=447716#file447716line162>
> >
> > I removed this test because ```QFile::open()``` will check that anyway
I just noted, we cannot release 4.8, yet. I broke the .annon.kmy file. If
that is used the account numbers of the stored payees will not be removed.
> Alvaro Soliverez hat am 29. November 2015 um 23:37
> geschrieben:
>
> Here are the draft notes for 4.8.0.
e/CMakeLists.txt a41a6a408e3da8769308dae75d4f514aa969dc87
Diff: https://git.reviewboard.kde.org/r/127376/diff/
Testing
---
Compiled on Linux.
Thanks,
Christian David
shown by the save dialog.
New: I tested it with GPG encrypted files.
Brand new: Tried to saved in locations I have no write premissions for, to
non-existing folders, and write protected files. I tried hard to reproduce bug
256750 - everything seems to be alright.
Thanks,
Christian David
/diff/
Testing
---
Compiled on Linux.
Thanks,
Christian David
premissions for, to
non-existing folders, and write protected files. I tried hard to reproduce bug
256750 - everything seems to be alright.
Thanks,
Christian David
. However that should not stop
you.).
- Christian David
On März 25, 2016, 11:44 nachm., Heiko Becker wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
-
kmymoney/kmymoney.cpp 0d0a317d753e9c48740180d13235163928687b2c
kmymoney/main.cpp cf77030aeb7de0f744bc2cf928514568d564e2e8
Diff: https://git.reviewboard.kde.org/r/127556/diff/
Testing
---
Started and closed the app.
Thanks,
Christian David
> On April 3, 2016, 2:37 p.m., Allan Anderson wrote:
> >
>
> Allan Anderson wrote:
> We have had discussons about this in the bug report. I think you are
> confusing the issue by stating your experience (using the Polish translation)
> as a general issue. For me, if I delete the csvimpor
The if() is very long and not needed here. However, I still do not know if
this is the issue. Also the ```i18nc()s``` from ```init()``` could go here if
the readSettings method is always called, which I do not know either.
- Christian David
On April 3, 2016, 6:45 a.m., Łukasz W
> On April 7, 2016, 9:59 p.m., Christian David wrote:
> > kmymoney/plugins/csvimport/investprocessing.cpp, line 1967
> > <https://git.reviewboard.kde.org/r/127559/diff/1/?file=455181#file455181line1967>
> >
> > Should become
> > ```m_shrsinList
Hi Mitch,
USE_QT_DESIGNER known to be broken. I recommend to compile KMyMoney without the
flag. Maybe it works if you enable it later – but probably not.
Greetings
Christian
> Mitch Frazier hat am 13. April 2016 um 04:59
> geschrieben:
> I've cloned kmymoney from the git repository and it bu
101 - 200 of 306 matches
Mail list logo
