----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127495/#review94008 -----------------------------------------------------------
Ship it! It looks very good (I could not tested it, yet. However that should not stop you.). - Christian David On März 25, 2016, 11:44 nachm., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127495/ > ----------------------------------------------------------- > > (Updated März 25, 2016, 11:44 nachm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > Added the KF5::ConfigGui target to target_link_libraries, otherwise > I get errors about the missing kconfigskeleton.h header. > Also included KLocalizedString rather than klocale.h, which belongs > to the previously removed KDELibs4Support (in > 1cf2e47b56163d0fb67c310a22f01e3bf2091ad2). > > > Diffs > ----- > > kmymoney/plugins/kbanking/CMakeLists.txt > 5aab91a4d26dc05fe3a0e2b4f0d7ab2b57330f1e > kmymoney/plugins/kbanking/widgets/CMakeLists.txt > 906c5e662178432a926ac7196e587573d3821eb5 > kmymoney/plugins/kbanking/widgets/kbaccountlist.cpp > 37a501a6ed977f933b19e0aa5c9782f9ba95f55f > > Diff: https://git.reviewboard.kde.org/r/127495/diff/ > > > Testing > ------- > > Successfully built kmymoney. > > > Thanks, > > Heiko Becker > >
