----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126882/#review91583 -----------------------------------------------------------
The review request looks good to me. Unfortunatly I cannot test it until the weekend. Can somebody do that for me? This request was made to implemet whislist item [#275004](https://bugs.kde.org/show_bug.cgi?id=275004) kmymoney/converter/webpricequote.h (line 184) <https://git.reviewboard.kde.org/r/126882/#comment62582> KUrl is depricated, should be ported to QUrl. kmymoney/converter/webpricequote.cpp <https://git.reviewboard.kde.org/r/126882/#comment62583> Is the code block after the ```if``` empty now? If yes it should be removed in favor of ```!d->m_filter.waitForStarted()```. Sorry if I am wrong, I cannot download your patch at the moment. kmymoney/converter/webpricequote.cpp (line 154) <https://git.reviewboard.kde.org/r/126882/#comment62584> That is a nice trick to create a temporary file! - Christian David On Jan. 25, 2016, 3:56 nachm., Artur Puzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126882/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 3:56 nachm.) > > > Review request for KMymoney and Christian David. > > > Repository: kmymoney > > > Description > ------- > > Changed to asynchronous download in converter/webpricequote using > `KIO::file_copy` > The code in dialogs/kequitypriceupdatedlg was ideal to code this feature. The > first download is triggered by `slotUpdateAllClicked`. Then the next > downloads are trigered by signals from `WebPriceQuote`. This makes the ideal > possibility to create assynchronous transfers as getting back to > `slotUpdateAllClicked` immidietly after starting the job haven't broke > anything. > > > Diffs > ----- > > kmymoney/converter/webpricequote.h 01db54da0c7321e541579bd8ac14c480ef314898 > kmymoney/converter/webpricequote.cpp > e97b71a3846b3cbf07ad7f88939495b8f47681d2 > > Diff: https://git.reviewboard.kde.org/r/126882/diff/ > > > Testing > ------- > > Autometed tests pass. > The feature seams to be working. Even in case of an error the downloads > continue. I teststed the funcionality when the "Update All" button is used. > > > Thanks, > > Artur Puzio > >
