> On Jan. 26, 2016, 9:01 a.m., Thomas Baumgart wrote: > > I cannot test the patch myself to check for any side-effects. So far it > > looks good to me. Can you please remove those extra trailing spaces shown > > in red in the diff view?
I tried the patch and could not find any issues. Other than stated this reviewrequest is based on master. So we can easily use it in KMyMoney 4.8 – on my current system I am unable to compile it. So I did not commit it, yet. - Christian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126882/#review91606 ----------------------------------------------------------- On Feb. 11, 2016, 10:45 p.m., Artur Puzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126882/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 10:45 p.m.) > > > Review request for KMymoney and Christian David. > > > Bugs: 275004 > http://bugs.kde.org/show_bug.cgi?id=275004 > > > Repository: kmymoney > > > Description > ------- > > Changed to asynchronous download in converter/webpricequote using > `KIO::file_copy`. > The code in dialogs/kequitypriceupdatedlg was ideal to code this feature. The > first download is triggered by `slotUpdateAllClicked`. Then the next > downloads are trigered by signals from `WebPriceQuote`. This makes the ideal > possibility to create assynchronous transfers as getting back to > `slotUpdateAllClicked` immidietly after starting the job haven't broke > anything. > > > Diffs > ----- > > kmymoney/converter/webpricequote.h 01db54da0c7321e541579bd8ac14c480ef314898 > kmymoney/converter/webpricequote.cpp > e97b71a3846b3cbf07ad7f88939495b8f47681d2 > > Diff: https://git.reviewboard.kde.org/r/126882/diff/ > > > Testing > ------- > > Autometed tests pass. > The feature seams to be working. Even in case of an error the downloads > continue. I teststed the funcionality when the "Update All" button is used. > > > Thanks, > > Artur Puzio > >
