> On Jan. 25, 2016, 11:55 a.m., Alvaro Soliverez wrote: > > kmymoney/converter/mymoneystatementreader.cpp, line 1451 > > <https://git.reviewboard.kde.org/r/126875/diff/2/?file=439606#file439606line1451> > > > > In this case, html tags could be added outside the i18n. By adding them > > within the statements, you're making strings fuzzy that translators will > > have to review and it could be avoided. > > It's not blocking, but if you have to modify the patch again, please > > keep it in mind.
It will be fixed if I push the change. - Christian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126875/#review91575 ----------------------------------------------------------- On Jan. 24, 2016, 11:07 p.m., Artur Puzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126875/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2016, 11:07 p.m.) > > > Review request for KMymoney and Christian David. > > > Repository: kmymoney > > > Description > ------- > > Moved the question from `TransactionMatcher::match` to > `MyMoneyStatementReader::askUserToEnterScheduleForMatching`. > Added `MyMoneyTransaction & importedTransaction` parmeter to > `MyMoneyStatementReader::askUserToEnterScheduleForMatching`, as > `importedTransation` is required to calculate if the question from > `TransactionMatcher::match` should be shown. > > > Diffs > ----- > > kmymoney/converter/mymoneystatementreader.h 80da202 > kmymoney/converter/mymoneystatementreader.cpp 1634bbb > kmymoney/dialogs/transactionmatcher.cpp 7d97404 > > Diff: https://git.reviewboard.kde.org/r/126875/diff/ > > > Testing > ------- > > Automated tests still pass, but they don't check the subject of work. > Screenshot: [link](https://imgur.com/3Veh70N) > > > Thanks, > > Artur Puzio > >
