> On Jan. 25, 2016, 11:55 vorm., Alvaro Soliverez wrote: > > Also, have Allan's concerns regarding the use of these calls by other > > modules been addressed?
Not yet. I think I checked that before I wrote the GCI task. Unfortunately I'll be unable to do so again until next week. We can leave the request in the queue until that issue is solved. - Christian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126875/#review91575 ----------------------------------------------------------- On Jan. 24, 2016, 11:07 nachm., Artur Puzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126875/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2016, 11:07 nachm.) > > > Review request for KMymoney and Christian David. > > > Repository: kmymoney > > > Description > ------- > > Moved the question from `TransactionMatcher::match` to > `MyMoneyStatementReader::askUserToEnterScheduleForMatching`. > Added `MyMoneyTransaction & importedTransaction` parmeter to > `MyMoneyStatementReader::askUserToEnterScheduleForMatching`, as > `importedTransation` is required to calculate if the question from > `TransactionMatcher::match` should be shown. > > > Diffs > ----- > > kmymoney/converter/mymoneystatementreader.h 80da202 > kmymoney/converter/mymoneystatementreader.cpp 1634bbb > kmymoney/dialogs/transactionmatcher.cpp 7d97404 > > Diff: https://git.reviewboard.kde.org/r/126875/diff/ > > > Testing > ------- > > Automated tests still pass, but they don't check the subject of work. > Screenshot: [link](https://imgur.com/3Veh70N) > > > Thanks, > > Artur Puzio > >
