> On Jan. 20, 2015, 2:23 nachm., Thomas Baumgart wrote: > > To me this looks like that uploaded patch is not based on the current > > master version. Please check that things are in sync, update the patch > > before we can review it.
Hi Shayantan, please dismiss this review request. Thank you! - Christian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122150/#review74387 ----------------------------------------------------------- On Jan. 19, 2015, 4:42 nachm., Shayantan Pal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122150/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 4:42 nachm.) > > > Review request for KMymoney and Christian David. > > > Repository: kmymoney > > > Description > ------- > > Feeds data to an SQLite Database from an excel file > > > Diffs > ----- > > kmymoney/mymoney/onlinejobtypedtest.cpp > 189df04413120050e26ad8199a31d2c68c8f2960 > kmymoney/mymoney/payeeidentifier/payeeidentifierdata.h > a6899c1f018a5b34dcf585e6b61995b6cb107ac0 > kmymoney/mymoney/onlinejobmessage.cpp > 3597364a198703f2356801bfddc434bda9d993c1 > kmymoney/mymoney/onlinejobtyped.h c23599f3b4b9523d11bbc31bb38c390068890572 > kmymoney/models/onlinejobmodel.h 8ff20bd1881d3e4a2605183d392baf92002dea1d > kmymoney/models/onlinejobmodel.cpp e369eed334cbd80770e41a15b19222db1079a1b2 > kmymoney/models/payeeidentifiermodel.cpp > 9fff26c6b615976ab621911b9b688f75d45d3087 > kmymoney/mymoney/mymoneypayeeidentifiercontainer.h > 190604416445ef26056fa021ff08fa8d2bfcb269 > kmymoney/mymoney/mymoneypayeeidentifiercontainer.cpp > c5cc8da3a2905da6157dfa29f10bed29eb86280e > kmymoney/mymoney/onlinejob.h 8ae40202e88e198189201d5325523b3fc01bd3e2 > kmymoney/mymoney/onlinejobadministration.h > 83650a1272be6e1660b18df335c1a5f202dfa990 > kmymoney/mymoney/onlinejobfolder.h b5a96c070b44849de461cae9cd81f31991fd2aa8 > kmymoney/mymoney/onlinejobfolder.cpp > 432fe7d8f938fd9a39057757210d0ee0e6e45294 > kmymoney/mymoney/onlinejobmessage.h > f520c25b69cee4406b9ffe10a377332bb008296d > kmymoney/misc/charvalidator.h PRE-CREATION > kmymoney/misc/charvalidator.cpp PRE-CREATION > kmymoney/CMakeLists.txt 653734a2d410de4070133f8ff6686bd416e1a913 > kmymoney/converter/mymoneystatementreader.cpp > 17eba4df32d5142ed16149917245b9529994a4e5 > kmymoney/dialogs/konlinetransferform.cpp > 6ab9a2f41a650fe96adc8f15994f7600150136f4 > kmymoney/dialogs/konlinetransferformdecl.ui > 7246541fb34db8dcbf9e59a722d272edd509ceb1 > kmymoney/kmymoney.cpp a3de0df5309b95ad507c501e74cb057c7cdad60a > kmymoney/kmymoneyutilstest.h bb75b60e79214e8b7f036c984738d129c4460d0f > kmymoney/kmymoneyutilstest.cpp 7be55c80874b1779832d619caf4b95c032013780 > kmymoney/misc/CMakeLists.txt ab29cfac55070a00db5df5a13d27b1ff93dd5867 > kmymoney/mymoney/payeeidentifier/payeeidentifiermacros.h > 96251afe1242977473c96514a16f6fce945305cc > kmymoney/mymoney/payeeidentifier/payeeidentifiertyped.h > 07d3abbe61cce60f5bec110038178ec4fbf0d6a7 > kmymoney/mymoney/storage/kmymoney-sqlstorageplugin.desktop > 3bd3531221f42a48adedb67db023699b6ee4a328 > kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp > 04873dc9568ab63cde637aad8a037a00dbede7e4 > kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp > c6a248967e1ba156534253b3200560ac281b9064 > kmymoney/mymoney/storage/mymoneystoragesql.h > ce65996452769e1beb6982205f9a781b7d0cc6f5 > kmymoney/mymoney/storage/mymoneystoragesql.cpp > a9049cc03cef650b4668f08f4987a65b8f27dcc2 > kmymoney/payeeidentifier/ibanandbic/CMakeLists.txt > 71aededa81e222784f7f6a85a9d71df4c1ac8697 > kmymoney/payeeidentifier/ibanandbic/bicmodel.h > 8611da4f45f62bc61b7e07ad2368ff22ab605ada > kmymoney/payeeidentifier/ibanandbic/bicmodel.cpp > 2caf8c10bde555f0db46680ace0013687bd06857 > kmymoney/payeeidentifier/ibanandbic/ibanbic.h > 399cc05f1b6e33e49062a1936bce070e5df6b1de > kmymoney/payeeidentifier/ibanandbic/ibanbic.cpp > 76c25ca29e2849e68eda0a0c73252f2d37c6125d > kmymoney/payeeidentifier/ibanandbic/ibanbicdata.h > ccfd8ff62e4fac73ec55a0fa49b5bfadd47d8d9b > kmymoney/payeeidentifier/ibanandbic/ibanbicdata.cpp > baca85b95393e786e1adb23ec40a312984dd503f > kmymoney/payeeidentifier/ibanandbic/ibanbicmacros.h > dd48be0b6adabe17209a0fd2b39df32a452bee77 > kmymoney/payeeidentifier/ibanandbic/ibanbicstorageplugin.cpp > 7b094ab08667094de8eb85983822fdf91a87a6ad > > kmymoney/payeeidentifier/ibanandbic/tests/internationalaccountidentifiertest.h > 568fdec141087593de3aecfcf317c7ac3dd407e0 > kmymoney/payeeidentifier/ibanandbic/widgets/ibanbicitemdelegate.h > 2cd3dd8ca69bdababd49b625197c34d03eeac06a > kmymoney/payeeidentifier/nationalaccount/CMakeLists.txt > 10795ec57a81310b098050f46280e5a74fd92afc > kmymoney/payeeidentifier/nationalaccount/nationalaccount.h > c16694b367b034d8a2dec55b2c65005d1f3d2c9e > kmymoney/payeeidentifier/nationalaccount/nationalaccountidmacros.h > 12953b9002e68d8be08950dccf975c617560a472 > kmymoney/payeeidentifier/nationalaccount/ui/nationaaccountedit.ui > 5acbe8733cbf51d58d65a0857f9542855b7e1a98 > kmymoney/payeeidentifier/unavailableplugin/unavailableplugin.h > 5d75832812df9d23d50fdc2c0f5a292f516ec8ab > kmymoney/payeeidentifier/unavailableplugin/unavailableplugin.cpp > dd6d534f9c73f7d88158ae74cc2ef7b662c646c5 > kmymoney/plugins/csvexport/kmm_csvexport.desktop > 3d27b6ca988bfebc824380125f8418100d385892 > kmymoney/plugins/csvimport/csvdialog.h > 780329dc00ab7bd05827ce8d50f734183f2738c4 > kmymoney/plugins/csvimport/csvdialog.cpp > b9863179b8abb9e90d3259b5e4e322202cc3f83f > kmymoney/plugins/csvimport/csvdialog.ui > 166b04a27a5c03f1f7dbe0983e9a3fd784fdad2f > kmymoney/plugins/csvimport/kmm_csvimport.desktop > 916e22892c53c8984e3ade5ce891caf40fdf2d9c > kmymoney/plugins/icalendarexport/kcm_kmm_icalendarexport.desktop > 3e249d16e8bb231faaa8a7ff7f6a38f63b7c11bb > kmymoney/plugins/kbanking/aqbankingkmmoperators.h > 3a3f3a23de4c66c5650b732c1ebd6ae5ff6ba019 > kmymoney/plugins/kbanking/aqbankingkmmoperators.cpp > 5a99ad816bc9372af9eed201514fee5320638ff2 > kmymoney/plugins/kbanking/gwenhywfarqtoperators.h > 0446e6ca40c8577b6c76be927cf3b99dcf4ec10e > kmymoney/plugins/kbanking/gwenhywfarqtoperators.cpp > 0a59e711fee313ac5f2f5dd4440ecac6d19af64e > kmymoney/plugins/kbanking/gwenkdegui.h > 962bf5f7d29f97f3a342009cb6a26365958e92b5 > kmymoney/plugins/kbanking/gwenkdegui.cpp > bed761d54a4d49c379c6899ba41535246bb4086f > kmymoney/plugins/kbanking/kmm_kbanking.desktop > de63ef584c1c0c25a126d2339e1aac808a0ada52 > kmymoney/plugins/kbanking/mymoneybanking.cpp > 211d4622d424f3e58f1fe4469da944c02cab22f2 > kmymoney/plugins/kbanking/qml/chipTan/ChipTanFlickerField.qml > 8ca84a7820155123416619e0e89d5844b8c88bf0 > kmymoney/plugins/kmymoney-onlinetaskui.desktop > 7d88755456b70b5c130c5b8e066638b213ad556d > kmymoney/plugins/kmymoney-payeeidentifierdelegate.desktop > 895e97c52e840c7226d4b0e4f8c052cf0390cd1d > kmymoney/plugins/ofximport/kmm_ofximport.desktop > 0c43d24ce27dd2d6c66d9cbaa42a4a0b46f831b8 > kmymoney/plugins/onlinejobpluginmockup/germancredittransfersettingsmockup.h > a68f8a8c9e4d02771a02522b4408f29c05776d13 > kmymoney/plugins/onlinejobpluginmockup/kmm_onlinejobpluginmockup.desktop > fbb14a7891d7a887f4d6a415186ee4ddcbe5d631 > kmymoney/plugins/onlinejobpluginmockup/onlinejobpluginmockup.cpp > dd533d37e19dacf67f58ceb9f6f0a1d4e99b4aaf > kmymoney/plugins/onlinetasks/dummy/tasks/dummytask.h > d8f2d82b15d3af092b94e2f5f95192850b097125 > kmymoney/plugins/onlinetasks/interfaces/converter/onlinetaskconverter.h > 87fd4cfdfb0041ff64aa27344917c9ac449edf16 > kmymoney/plugins/onlinetasks/interfaces/tasks/credittransfer.h > 7ed73744419187beeaacaa7fb2bfb588c3813182 > kmymoney/plugins/onlinetasks/interfaces/tasks/onlinetask.h > 266b9246cb368e10c2b8fef6c0289d90dce90305 > kmymoney/plugins/onlinetasks/national/CMakeLists.txt > 18585001e8332d72b5016df66154206b3804d1e4 > kmymoney/plugins/onlinetasks/national/nationalonlinetasksloader.cpp > f8c68db0a14fd7d4dcce3504d227ee57b5f0fb9e > kmymoney/plugins/onlinetasks/national/nationalstorageplugin.cpp > 3899d3a88878f15873b3ab3d9d87bbab2f199fd9 > kmymoney/plugins/onlinetasks/national/tasks/germanonlinetransferimpl.cpp > cc1871048b5b6b3c1fc7c5a22a6227742a570ef1 > kmymoney/plugins/onlinetasks/national/tests/CMakeLists.txt > 0a3a4f498917ac3676c37fbc903c668323bb43b9 > kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.cpp > 9a87313ff02762e6ddad652bb095b3f6519899ea > kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.ui > 919a6d672adba3142e61cac8851642ada7f7fde0 > kmymoney/plugins/onlinetasks/sepa/sepaonlinetasksloader.cpp > 91bbb6b553980c0d7bece371032f1e36e825a422 > kmymoney/plugins/onlinetasks/sepa/sepastorageplugin.cpp > 18165552b87520520c57086603480c68a73a00d8 > kmymoney/plugins/onlinetasks/sepa/tasks/sepaonlinetransferimpl.cpp > 3012b40b6549cad943ef0877c9c1d914f46aaa64 > kmymoney/plugins/onlinetasks/sepa/ui/sepacredittransferedit.cpp > 98a6be2a7ee1ace8d95191c31ac7eec1bb53ed05 > kmymoney/plugins/onlinetasks/sepa/ui/sepacredittransferedit.ui > 22ae0c6d23d5486cc2ebe243e4f351d7d32e3dbb > kmymoney/plugins/onlinetasks/unavailabletask/tasks/unavailabletask.h > 6650ba5b03380d05255bf3bd880c1a2ee5b6ca97 > kmymoney/plugins/onlinetasks/unavailabletask/tasks/unavailabletask.cpp > d5e064066fd6e5c5cbcc8a2e6dccc6e9839f13cf > kmymoney/plugins/printcheck/kcm_kmm_printcheck.desktop > a42ad50240c01f5d1765de5f31da0382ac53e62e > kmymoney/plugins/printcheck/kmm_printcheck.desktop > 8217f14f3151ca6f121bd651bbecc02393487372 > kmymoney/plugins/sqlcipher/qsqlcipherdriverplugin.cpp > 886993fea3aa3c274746f8d1ee614c62b540d705 > kmymoney/views/khomeview.cpp 2cbe6cdb1feb935e9384ba80ee6b927cee869464 > kmymoney/views/kmymoneyview.cpp 52843f4fccb9cbd329c69617e228d6f6af056f54 > kmymoney/views/konlinejoboutbox.h df60466e0dfc52fada65aec701a9ac5235383108 > kmymoney/views/konlinejoboutbox.cpp > bb43e890360ba0d17e422f4fcfdf228e515a9d98 > kmymoney/views/konlinejoboutbox.ui 8a6f37d094844e41b10dedf65851fe363333c9a1 > kmymoney/views/kreportsview.cpp c02e89f6b4b59f6c26994821824a87ad7e1a4082 > kmymoney/views/payeeidentifierselectiondelegate.h > 655df4c21afe6a976314b423d51791aba7ee2386 > kmymoney/views/payeeidentifierselectiondelegate.cpp > b6dd586b470e47d5eeff6485931bd996d6594bff > kmymoney/widgets/CMakeLists.txt 36c7b86ccb35f614d9c891418ddf4b34e88ae13e > kmymoney/widgets/fixedcolumntreeview.h > 3ef39c9f18a90f7cba13b3239d751411366ef745 > kmymoney/widgets/kmymoney_export.h a3d4562af0ffea8c38d8b725a42aec16cc3214b0 > kmymoney/widgets/kmymoneymvccombo.cpp > 41ae18857f9451eca56a172aafa0b8e2d53177f2 > kmymoney/widgets/kmymoneytextedit_p.h > bb8a20fa2f6e2088d8f210307e921c70417cf88c > kmymoney/widgets/kmymoneyvalidationfeedback.ui > b5ff21ee5131965d7260be02df882f7cbc256c4a > tools/CMakeLists.txt 169c5d80c325d05322e7467b33e01314a264c3c8 > tools/xea2kmt.cpp a5bc5699c07289f0631cf8a2708ca014847f93f5 > > Diff: https://git.reviewboard.kde.org/r/122150/diff/ > > > Testing > ------- > > > Thanks, > > Shayantan Pal > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
