zacharymorn commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-804683838
Thanks Robert for working on this! And yeah I didn't quite anticipate so
much dead code lingering around when I created the issue! From your latest
comment this PR is very much r
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306604#comment-17306604
]
Dawid Weiss edited comment on LUCENE-9861 at 3/23/21, 7:38 AM:
---
dweiss commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-804690276
> Is the plan to have both ecj & error prone to co-exist in Lucene to catch
different kinds of bugs?
I think the union of all these tools is different than their intersection so
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306875#comment-17306875
]
Uwe Schindler commented on LUCENE-9861:
---
+1 for committing
> speed up precommit
>
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reassigned LUCENE-9862:
---
Assignee: Dawid Weiss
> gradlew regenerate doesnt invoke jflexStandardTokenizerImpl
> -
dweiss commented on a change in pull request #33:
URL: https://github.com/apache/lucene/pull/33#discussion_r599370747
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -74,9 +74,6 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties",
file
uschindler commented on a change in pull request #33:
URL: https://github.com/apache/lucene/pull/33#discussion_r599375420
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -74,9 +74,6 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties",
dweiss opened a new pull request #35:
URL: https://github.com/apache/lucene/pull/35
Cleanup of all regenerate tasks; moved common code into a shared bit. Added
failOnError for ant.patch. Included jflexStandardTokenizerImpl.
There is an occasional weirdness/ race with spotless where s
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306923#comment-17306923
]
Dawid Weiss commented on LUCENE-9862:
-
U updated the code slightly and I get an erro
dweiss merged pull request #33:
URL: https://github.com/apache/lucene/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please conta
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9861.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> speed up precommit
> --
>
>
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306925#comment-17306925
]
ASF subversion and git services commented on LUCENE-9861:
-
Commi
uschindler commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599417385
##
File path: lucene/core/src/test/org/apache/lucene/search/TestTotalHits.java
##
@@ -22,6 +22,7 @@
public class TestTotalHits extends LuceneTestCase {
rmuir commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599482236
##
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/cjk/TestCJKBigramFilterFactory.java
##
@@ -56,11 +56,10 @@ public void testHanOnlyUnigr
rmuir commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599482948
##
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestAnalyzers.java
##
@@ -109,7 +109,9 @@ public void _testStandardConstants() {
rmuir commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599486860
##
File path: lucene/core/src/test/org/apache/lucene/search/TestTotalHits.java
##
@@ -22,6 +22,7 @@
public class TestTotalHits extends LuceneTestCase {
+ @
rmuir commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599489397
##
File path: gradle/generation/javacc.gradle
##
@@ -95,6 +95,12 @@ def commonCleanups = { FileTree generatedFiles ->
text = text.replace(
"pub
rmuir commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599491781
##
File path: gradle/generation/javacc.gradle
##
@@ -95,6 +95,12 @@ def commonCleanups = { FileTree generatedFiles ->
text = text.replace(
"pub
Robert Muir created LUCENE-9863:
---
Summary: run spotless across groovy (e.g. gradle) code too
Key: LUCENE-9863
URL: https://issues.apache.org/jira/browse/LUCENE-9863
Project: Lucene - Core
Issue
uschindler commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r59952
##
File path: gradle/generation/javacc.gradle
##
@@ -95,6 +95,12 @@ def commonCleanups = { FileTree generatedFiles ->
text = text.replace(
uschindler commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599501850
##
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/cjk/TestCJKBigramFilterFactory.java
##
@@ -56,11 +56,10 @@ public void testHanOnly
rmuir commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599501947
##
File path: gradle/generation/javacc.gradle
##
@@ -95,6 +95,12 @@ def commonCleanups = { FileTree generatedFiles ->
text = text.replace(
"pub
uschindler commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599502396
##
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/cjk/TestCJKBigramFilterFactory.java
##
@@ -56,11 +56,10 @@ public void testHanOnly
uschindler commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599502396
##
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/cjk/TestCJKBigramFilterFactory.java
##
@@ -56,11 +56,10 @@ public void testHanOnly
rmuir commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599506794
##
File path: gradle/generation/javacc.gradle
##
@@ -95,6 +95,12 @@ def commonCleanups = { FileTree generatedFiles ->
text = text.replace(
"pub
rmuir commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599507851
##
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/cjk/TestCJKBigramFilterFactory.java
##
@@ -56,11 +56,10 @@ public void testHanOnlyUnigr
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306997#comment-17306997
]
Robert Muir commented on LUCENE-9861:
-
Thank you [~dweiss], this one really helps my
uschindler commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599514548
##
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/cjk/TestCJKBigramFilterFactory.java
##
@@ -56,11 +56,10 @@ public void testHanOnly
rmuir commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-804859947
> Thanks Robert for working on this! And yeah I didn't quite anticipate so
much dead code lingering around when I created the issue! From your latest
comment this PR is very much ready
uschindler commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-804866653
> On the other hand, ECJ is a "compiler", but with a lot of nice checks.
Maybe they are not as fancy as the kind of checks that error-prone might be
able to do, instead they are s
uschindler edited a comment on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-804866653
> On the other hand, ECJ is a "compiler", but with a lot of nice checks.
Maybe they are not as fancy as the kind of checks that error-prone might be
able to do, instead the
rmuir commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-804870224
I was also pleasantly surprised to see how well maintained this compiler is.
It is nice to see things like JDK16 support, as opposed to error-prone which
reaches into java internals an
[
https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307017#comment-17307017
]
ASF subversion and git services commented on LUCENE-9861:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307019#comment-17307019
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307018#comment-17307018
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307021#comment-17307021
]
Dawid Weiss commented on LUCENE-9856:
-
> Gradle has single quotes instead of double
[
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307026#comment-17307026
]
Dawid Weiss commented on LUCENE-9863:
-
Contrary to Java, I've had a poor experience
[
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307033#comment-17307033
]
Robert Muir commented on LUCENE-9863:
-
Does it just need more maturity before it can
[
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307036#comment-17307036
]
Dawid Weiss commented on LUCENE-9863:
-
Isn't it the same experience with any new pro
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307057#comment-17307057
]
Dawid Weiss commented on LUCENE-9862:
-
Hi Robert ([~rmuir]) - do you know why the sn
mikemccand commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r599557787
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -388,6 +434,26 @@ private void processFacetFields(
}
}
+ priv
mikemccand commented on a change in pull request #32:
URL: https://github.com/apache/lucene/pull/32#discussion_r599588929
##
File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java
##
@@ -231,4 +239,13 @@ protected final int readerBase(int readerIndex)
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307111#comment-17307111
]
Robert Muir commented on LUCENE-9862:
-
Oh man, it is probably a bug. This thing is p
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307113#comment-17307113
]
Dawid Weiss commented on LUCENE-9862:
-
There is no rush at all. I think it'd make se
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307122#comment-17307122
]
Robert Muir commented on LUCENE-9862:
-
I must have messed it up the last time I upgr
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307125#comment-17307125
]
Dawid Weiss commented on LUCENE-9862:
-
Leave it. I'll take a peek later today.
> gr
[
https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307146#comment-17307146
]
Adrien Grand commented on LUCENE-9827:
--
The "more than 1% dirty docs" condition bec
rmuir merged pull request #34:
URL: https://github.com/apache/lucene/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contac
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307155#comment-17307155
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9856.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> Improve static analysis to catch dead code
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307165#comment-17307165
]
Michael McCandless commented on LUCENE-9850:
This is very cool [~gsmiller]!
[
https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307177#comment-17307177
]
Robert Muir commented on LUCENE-9827:
-
[~jpountz] As far as the "1% dirty docs", it
mikemccand opened a new pull request #36:
URL: https://github.com/apache/lucene/pull/36
Spinoff from https://github.com/apache/lucene/pull/32.
I think `static` is pointless in front of `enum`? So this just removes
those `static` ... it'd be nice to fix our style checker / spotless t
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307186#comment-17307186
]
Adrien Grand commented on LUCENE-9850:
--
I wonder if it would help to make the encod
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307210#comment-17307210
]
Michael McCandless commented on LUCENE-9850:
Here's the result of {{bpv-tool
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307218#comment-17307218
]
Adrien Grand commented on LUCENE-9850:
--
Maybe that's due to the terms that are extr
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307218#comment-17307218
]
Adrien Grand edited comment on LUCENE-9850 at 3/23/21, 4:45 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307222#comment-17307222
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir reopened LUCENE-9856:
-
I reverted this due to test failures. I will look into it, I think i angered
the attributes.
> Imp
uschindler commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-805065787
When you fixed the stuff, maybe reopen a new pull request with same branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307226#comment-17307226
]
Greg Miller commented on LUCENE-9850:
-
{quote}I wonder if it would help to make the
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307227#comment-17307227
]
Uwe Schindler commented on LUCENE-9856:
---
{quote}
bq. Gradle has single quotes inst
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307227#comment-17307227
]
Uwe Schindler edited comment on LUCENE-9856 at 3/23/21, 5:00 PM:
-
mikemccand merged pull request #36:
URL: https://github.com/apache/lucene/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
rmuir commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-805086733
I still have the branch locally. I think the fix is to revert this commit:
https://github.com/apache/lucene/pull/34/commits/7d823c84e3f7b6bebd25eda76f9e482016c78868
Redundant sup
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307270#comment-17307270
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307271#comment-17307271
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
rmuir opened a new pull request #37:
URL: https://github.com/apache/lucene/pull/37
I went too far with the previous PR and it broke the build.
The problem was `redundantSuperInterface` which basically tries to tell you
that you dont need `extends ArrayList implements List` because `A
[
https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307272#comment-17307272
]
Adrien Grand commented on LUCENE-9827:
--
Agreed that having approximate statistics i
rmuir merged pull request #37:
URL: https://github.com/apache/lucene/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contac
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307284#comment-17307284
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
uschindler commented on pull request #37:
URL: https://github.com/apache/lucene/pull/37#issuecomment-805119396
Hi @rmuir,
I will dig into the `TermToBytesRefAttribute` issue, but I know why it
fails. The reason is that TermToBytesRefAttribute is a superinterface of the
actual `CharTerm
uschindler opened a new pull request #38:
URL: https://github.com/apache/lucene/pull/38
This fixes the remaining change in #37, see comment
https://github.com/apache/lucene/pull/37#issuecomment-805119396
> Hi @rmuir,
> I will dig into the TermToBytesRefAttribute issue, but I know
uschindler commented on pull request #38:
URL: https://github.com/apache/lucene/pull/38#issuecomment-805169097
The problem here is specific to BytesTermAttribute. In contrast
CharTermAttribute does not have the issue:
- TermToBytesRefAttribute defines getBytes()
- Because BytesTer
uschindler commented on pull request #38:
URL: https://github.com/apache/lucene/pull/38#issuecomment-805180200
In short: the PR fixes the issue but the design is still broken since Lucene
4.0 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307382#comment-17307382
]
Robert Muir commented on LUCENE-9850:
-
Maybe rather than power of two, try a list so
jimczi commented on a change in pull request #32:
URL: https://github.com/apache/lucene/pull/32#discussion_r599954418
##
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##
@@ -56,7 +57,24 @@
* @throws IOException if there is a low-level IO error
mayya-sharipova commented on pull request #11:
URL: https://github.com/apache/lucene/pull/11#issuecomment-805296177
I've run indexing benchmarking using
[luceneutil](https://github.com/mikemccand/luceneutil). And here are the
results:
- indexing time in ms
- baseline: master bran
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307439#comment-17307439
]
Dawid Weiss commented on LUCENE-9862:
-
I know what this is - it tries to apply the s
rmuir commented on pull request #38:
URL: https://github.com/apache/lucene/pull/38#issuecomment-805351590
IMO it is arguably strange that AttributeSource "crawls" up the class
hierarchy but not the interfaces too?
https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/l
uschindler commented on pull request #38:
URL: https://github.com/apache/lucene/pull/38#issuecomment-805355226
Thanks Robert for review. I added a few tests to verify that all
TokenStreams have at least a TermToBytesRefAttribute, implemented by correct
class. For standard UTF-16 streams us
zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600111254
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -388,6 +434,26 @@ private void processFacetFields(
}
}
+ pri
zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600111781
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -408,7 +475,7 @@ private void processSSDVFacetFields(
doc.add(
zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600112047
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -388,6 +434,26 @@ private void processFacetFields(
}
}
+ pri
zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600112770
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -168,14 +203,34 @@ public synchronized void setIndexFieldName(String
d
zacharymorn commented on pull request #25:
URL: https://github.com/apache/lucene/pull/25#issuecomment-805432620
> This is looking close; thanks @zacharymorn!
>
> And thank you for opening the spinoff issue
https://issues.apache.org/jira/browse/LUCENE-9856 -- it now has a life all its
Zach Chen created LUCENE-9864:
-
Summary: Enforce @Override annotation with static analysis
Key: LUCENE-9864
URL: https://issues.apache.org/jira/browse/LUCENE-9864
Project: Lucene - Core
Issue Typ
[
https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach Chen updated LUCENE-9864:
--
Summary: Enforce @Override annotation with ecj static analysis
configuration (was: Enforce @Override
[
https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach Chen updated LUCENE-9864:
--
Description: This is a spin-off issue from
https://issues.apache.org/jira/browse/LUCENE-9856, where ec
zacharymorn commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-805464492
> > Is the plan to have both ecj & error prone to co-exist in Lucene to
catch different kinds of bugs?
>
> I think the union of all these tools is different than their inte
zacharymorn edited a comment on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-805464492
> > Is the plan to have both ecj & error prone to co-exist in Lucene to
catch different kinds of bugs?
>
> I think the union of all these tools is different than the
91 matches
Mail list logo
