rmuir commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599482948
##########
File path:
lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestAnalyzers.java
##########
@@ -109,7 +109,9 @@ public void _testStandardConstants() {
x = StandardTokenizer.HIRAGANA;
x = StandardTokenizer.KATAKANA;
x = StandardTokenizer.HANGUL;
+ assert x >= 0;
Review comment:
the entire test is crazy, recommend looking at it in context. It is a
"compile-time" "test" to ensure the constants are "public". We can remove the
asserts, now that `SuppressWarnings("unused")` does the right thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]