rmuir commented on pull request #34:
URL: https://github.com/apache/lucene/pull/34#issuecomment-805086733


   I still have the branch locally. I think the fix is to revert this commit: 
https://github.com/apache/lucene/pull/34/commits/7d823c84e3f7b6bebd25eda76f9e482016c78868
   
   Redundant superinterface was too aggressive on my part. I was trying to 
enable checks around "unnecessary code" and this was one of them, but I think 
it borked the attributes? Seems it should be deferred for now, the gain isn't 
worth the pain :)
   
   We may still enable the `unusedLabel` check from that commit, I think it is 
safe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to