[
https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach Chen updated LUCENE-9864:
------------------------------
Description: This is a spin-off issue from
https://issues.apache.org/jira/browse/LUCENE-9856, where ecj configuration was
updated to catch dead code and lots of dead code was removed. In this issue, we
would like to continue the clean up by enforcing *@Override* usage with
*org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=error*
configuration, and fix problems that arise. (was: When working on PR
[https://github.com/apache/lucene/pull/25,] we noticed that some dead code is
not being caught during static analysis in gradle build, such as the *start*
variable in the following code:
[https://github.com/apache/lucene/blob/a5996dbecd4a6b4147d961260711a2cb6aeab3d3/lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java#L446-L456]
We may need to look at if additional javac compiler flag, or configuration for
*error prone,* should be added to catch such bug as well as other potential
ones.)
> Enforce @Override annotation with static analysis
> -------------------------------------------------
>
> Key: LUCENE-9864
> URL: https://issues.apache.org/jira/browse/LUCENE-9864
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Reporter: Zach Chen
> Priority: Minor
> Labels: build
> Fix For: main (9.0)
>
>
> This is a spin-off issue from
> https://issues.apache.org/jira/browse/LUCENE-9856, where ecj configuration
> was updated to catch dead code and lots of dead code was removed. In this
> issue, we would like to continue the clean up by enforcing *@Override* usage
> with *org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=error*
> configuration, and fix problems that arise.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
