rmuir commented on a change in pull request #34:
URL: https://github.com/apache/lucene/pull/34#discussion_r599507851



##########
File path: 
lucene/analysis/common/src/test/org/apache/lucene/analysis/cjk/TestCJKBigramFilterFactory.java
##########
@@ -56,11 +56,10 @@ public void testHanOnlyUnigrams() throws Exception {
 
   /** Test that bogus arguments result in exception */
   public void testBogusArguments() throws Exception {
-    IllegalArgumentException expected =

Review comment:
       I honestly don't think there is a lot of the behavior going on. Maybe 
because IDEs tend to issue warnings when you do this? 
   
   We fixed only about 140 violations for this check total across the whole 
codebase including tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to